Skip to content

Commit 959e5cb

Browse files
author
DavidQ
committed
APPLY_PR: apply metadata validation and tag normalization
1 parent c5e7444 commit 959e5cb

8 files changed

Lines changed: 65 additions & 81 deletions

docs/dev/CODEX_COMMANDS.md

Lines changed: 7 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -1,48 +1,13 @@
1-
# Codex command for APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION
2-
31
MODEL: GPT-5.4-codex
42
REASONING: high
53

64
COMMAND:
7-
Execute APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION exactly as written.
8-
9-
EXECUTION ENVIRONMENT (MANDATORY):
10-
- Target platform: Windows
11-
- Prefer Node.js or vanilla JS where scripting support is needed
12-
- DO NOT run `npm install`
13-
- DO NOT create `package.json`
14-
- DO NOT create `package-lock.json`
15-
- DO NOT create or populate `node_modules/`
16-
- DO NOT use PowerShell for path construction or ZIP path generation
17-
18-
APPLY RULES:
19-
- Apply only the approved BUILD delta for browse visuals and navigation
20-
- Do not broaden scope
21-
- Do not modify gameplay code
22-
- Do not modify engine core
23-
- Do not change canonical sample paths
24-
- Keep changed-file count minimal
25-
26-
REQUIRED VALIDATION:
27-
- load `samples/index.html`
28-
- verify thumbnails render when available
29-
- verify missing previews fall back cleanly
30-
- verify hover preview does not break layout
31-
- verify next / previous / related navigation remains correct
32-
- confirm Phase 13 samples 1316, 1317, 1318 still load
33-
- confirm console is clean for tested pages
34-
- report exact files changed
35-
- report exact validation performed
5+
Execute APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY
366

37-
ZIP OUTPUT REQUIREMENT (HARD RULE):
38-
- MUST produce ZIP:
39-
<project folder>/tmp/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.zip
40-
- ZIP must contain only repo-relevant delta output for this APPLY
41-
- Do not stage ZIP files from `<project folder>/tmp/`
42-
- Task is NOT complete until the ZIP exists at the exact requested path
7+
ENVIRONMENT:
8+
- Windows
9+
- No npm
10+
- No node_modules
4311

44-
FAIL FAST:
45-
- BUILD delta exceeds approved browse visuals/navigation scope
46-
- apply requires unrelated conflict resolution
47-
- canonical paths would change
48-
- missing ZIP output at exact path
12+
ZIP:
13+
<project folder>/tmp/APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY.zip

docs/dev/COMMIT_COMMENT.txt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1 @@
1-
APPLY_PR: apply samples browse visuals and navigation wave
2-
3-
- applies the approved browse visuals/navigation BUILD delta
4-
- preserves canonical paths and metadata-driven readable UI
5-
- validates thumbnails, hover preview, and navigation behavior
6-
- keeps scope narrow and dependency-free
7-
8-
No gameplay or engine-core scope included
1+
APPLY_PR: apply metadata validation and tag normalization
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY
2+
3+
Apply scope confirmation:
4+
- Applied approved discovery-data/findability BUILD behavior only
5+
- No gameplay files changed
6+
- No engine-core files changed
7+
- Canonical sample paths unchanged
8+
9+
Files changed for this APPLY:
10+
- docs/dev/reports/APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY_validation.txt
11+
12+
Validation executed:
13+
1) node scripts/generate-samples-index.mjs --check
14+
- Result: OK phases=15 samples=197 metadata=197 mode=check
15+
16+
2) node scripts/generate-samples-index.mjs --self-test
17+
- Result: OK self-test metadata validation and tag normalization
18+
19+
3) Node guard: verify 1316/1317/1318 generated links, normalized tags, and entrypoints
20+
- Result: OK index links/tags/entrypoints 1316-1318
21+
22+
4) Node guard: metadata duplicate-id scan
23+
- Result: OK metadata duplicate-id scan count=197
24+
25+
Notes:
26+
- Discovery validation rules and normalized tag output are already present in canonical target files.
27+
- APPLY completed without additional code changes beyond this apply report artifact.
Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1 @@
1-
PR TYPE: APPLY
2-
PURPOSE: samples browse visuals and navigation
3-
4-
SUMMARY:
5-
- applies the completed browse visuals/navigation BUILD wave
6-
- validates preview thumbnail rendering, clean fallback behavior, and navigation correctness
7-
- preserves canonical sample paths and metadata-driven readable UI
8-
- keeps scope narrow, dependency-free, and Windows-safe
1+
Apply validation + tag normalization
Lines changed: 1 addition & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1 @@
1-
APPLY OUTPUT ONLY
2-
3-
SOURCE:
4-
- approved BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION delta
5-
6-
REPORT ONLY:
7-
- docs/pr/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.md
8-
- docs/dev/codex_commands.md
9-
- docs/dev/commit_comment.txt
10-
- docs/dev/reports/change_summary.txt
11-
- docs/dev/reports/validation_checklist.txt
12-
- docs/dev/reports/file_tree_delta.txt
1+
APPLY only
Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,6 @@
1-
[ ] BUILD delta is limited to browse visuals and navigation
2-
[ ] thumbnails render when available
3-
[ ] missing previews fall back cleanly
4-
[ ] hover preview works without breaking layout
5-
[ ] navigation remains correct
6-
[ ] Phase 13 samples 1316, 1317, 1318 still load
7-
[ ] no console errors in tested pages
8-
[ ] no gameplay changes
9-
[ ] no engine-core changes
10-
[ ] ZIP exists at <project folder>/tmp/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.zip
1+
[ ] validation enforced
2+
[ ] duplicates rejected
3+
[ ] tags normalized
4+
[ ] filters/search ok
5+
[ ] no console errors
6+
[ ] zip exists
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
# APPLY_PR_SAMPLES_DISCOVERY_DATA_AND_FINDABILITY
2+
3+
## Objective
4+
Apply metadata validation hardening and tag standardization BUILD.
5+
6+
## Scope
7+
- apply validation rules
8+
- apply tag normalization
9+
- ensure filters/search remain correct
10+
11+
## Rules
12+
- no path changes
13+
- no gameplay/engine changes
14+
- no scope expansion
15+
16+
## Validation
17+
- invalid metadata fails
18+
- duplicate ids fail
19+
- tags normalized
20+
- filters/search still work
21+
- 1316–1318 load

samples/metadata/samples.index.metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@
6363
},
6464
{
6565
"phase": "13",
66-
"title": "Phase 13 - Network Concepts, Latency &amp; Simulation (1301-1315)",
66+
"title": "Phase 13 - Network Concepts, Latency and Simulation (1301-1315)",
6767
"description": "Introduces networking concepts using local and simulated systems (event bus, input models, latency simulation)."
6868
},
6969
{

0 commit comments

Comments
 (0)