Skip to content

Commit c5e7444

Browse files
author
DavidQ
committed
APPLY_PR: apply samples browse visuals and navigation wave
- applies the approved browse visuals/navigation BUILD delta - preserves canonical paths and metadata-driven readable UI - validates thumbnails, hover preview, and navigation behavior - keeps scope narrow and dependency-free No gameplay or engine-core scope included
1 parent f35d7e7 commit c5e7444

6 files changed

Lines changed: 94 additions & 76 deletions

‎docs/dev/CODEX_COMMANDS.md‎

Lines changed: 21 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,79 +1,48 @@
1-
# Codex command for BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION
1+
# Codex command for APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION
22

33
MODEL: GPT-5.4-codex
44
REASONING: high
55

66
COMMAND:
7-
Execute BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION exactly as written.
7+
Execute APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION exactly as written.
88

99
EXECUTION ENVIRONMENT (MANDATORY):
1010
- Target platform: Windows
11-
- Prefer Node.js or vanilla JS for any scripting or generation support
11+
- Prefer Node.js or vanilla JS where scripting support is needed
1212
- DO NOT run `npm install`
1313
- DO NOT create `package.json`
1414
- DO NOT create `package-lock.json`
1515
- DO NOT create or populate `node_modules/`
16-
- DO NOT use PowerShell for path construction, rename-heavy work, or ZIP path generation
16+
- DO NOT use PowerShell for path construction or ZIP path generation
1717

18-
POWERSHELL PROHIBITION (CRITICAL):
19-
The following patterns are NOT allowed:
20-
- "$var/path"
21-
- "${var}/path"
22-
- "$base\$child"
23-
- "$($var)/path"
18+
APPLY RULES:
19+
- Apply only the approved BUILD delta for browse visuals and navigation
20+
- Do not broaden scope
21+
- Do not modify gameplay code
22+
- Do not modify engine core
23+
- Do not change canonical sample paths
24+
- Keep changed-file count minimal
2425

25-
If any of these appear:
26-
- STOP
27-
- report the violation
28-
- do not silently retry
29-
30-
PR PURPOSE:
31-
Improve samples index responsiveness and add lightweight favorites / pinning in one narrow, testable wave.
32-
33-
EXPECTED TARGETS:
34-
- `samples/index.html`
35-
- minimal JS/CSS directly supporting index rendering, filtering, and favorites behavior
36-
- metadata-driven files directly needed for persistence keys or rendering
37-
- reporting docs under `docs/`
38-
39-
DO NOT:
40-
- modify gameplay code
41-
- modify engine core
42-
- change canonical paths
43-
- broaden scope beyond index performance and lightweight personalization
44-
- modify `docs/dev/start_of_day/chatGPT/`
45-
- modify `docs/dev/start_of_day/codex/`
46-
47-
REQUIRED IMPLEMENTATION SHAPE:
48-
1. Improve index responsiveness without broad architectural rewrites
49-
2. Keep filter/search correctness intact
50-
3. Add dependency-free favorites / pinning using lightweight client-side persistence
51-
4. Preserve canonical links and metadata-driven readable UI
52-
5. Keep changed-file count minimal
53-
54-
VALIDATION (REQUIRED):
26+
REQUIRED VALIDATION:
5527
- load `samples/index.html`
56-
- verify filter/search still works correctly
57-
- verify repeated interactions remain responsive
58-
- add favorites / pins and confirm they render correctly
59-
- reload and confirm favorites / pins persist locally
60-
- remove a favorite / pin and confirm removal persists
28+
- verify thumbnails render when available
29+
- verify missing previews fall back cleanly
30+
- verify hover preview does not break layout
31+
- verify next / previous / related navigation remains correct
6132
- confirm Phase 13 samples 1316, 1317, 1318 still load
6233
- confirm console is clean for tested pages
6334
- report exact files changed
6435
- report exact validation performed
6536

6637
ZIP OUTPUT REQUIREMENT (HARD RULE):
6738
- MUST produce ZIP:
68-
<project folder>/tmp/BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION.zip
69-
- ZIP must contain only repo-relevant delta output for this PR
39+
<project folder>/tmp/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.zip
40+
- ZIP must contain only repo-relevant delta output for this APPLY
7041
- Do not stage ZIP files from `<project folder>/tmp/`
7142
- Task is NOT complete until the ZIP exists at the exact requested path
7243

7344
FAIL FAST:
74-
- vague target files
75-
- performance work requires broad rendering rewrite
76-
- favorites requires server-side persistence
77-
- persistence becomes coupled to unrelated systems
78-
- PowerShell parse issue before execution
45+
- BUILD delta exceeds approved browse visuals/navigation scope
46+
- apply requires unrelated conflict resolution
47+
- canonical paths would change
7948
- missing ZIP output at exact path

‎docs/dev/COMMIT_COMMENT.txt‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
BUILD_PR: improve samples index responsiveness and add favorites/pinning
1+
APPLY_PR: apply samples browse visuals and navigation wave
22

3-
- tighten samples index rendering/update behavior for repeated browse flows
4-
- add lightweight favorites / pinning with local persistence
5-
- preserve canonical paths and metadata-driven readable UI
6-
- keep implementation dependency-free and Windows-safe
3+
- applies the approved browse visuals/navigation BUILD delta
4+
- preserves canonical paths and metadata-driven readable UI
5+
- validates thumbnails, hover preview, and navigation behavior
6+
- keeps scope narrow and dependency-free
77

88
No gameplay or engine-core scope included

‎docs/dev/reports/change_summary.txt‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
PR TYPE: BUILD
2-
PURPOSE: samples index performance and personalization
1+
PR TYPE: APPLY
2+
PURPOSE: samples browse visuals and navigation
33

44
SUMMARY:
5-
- defines a testable BUILD wave for index responsiveness and favorites/pinning
5+
- applies the completed browse visuals/navigation BUILD wave
6+
- validates preview thumbnail rendering, clean fallback behavior, and navigation correctness
67
- preserves canonical sample paths and metadata-driven readable UI
7-
- requires lightweight client-side persistence only
88
- keeps scope narrow, dependency-free, and Windows-safe

‎docs/dev/reports/file_tree_delta.txt‎

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,10 @@
1-
EXPECTED DELTA (implementation-dependent, keep minimal)
1+
APPLY OUTPUT ONLY
22

3-
MODIFIED:
4-
- samples/index.html
5-
- minimal JS/CSS directly supporting index rendering/performance/favorites behavior
6-
7-
ADDED (only if required):
8-
- minimal persistence helper directly used by the samples index
3+
SOURCE:
4+
- approved BUILD_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION delta
95

106
REPORT ONLY:
11-
- docs/pr/BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION.md
7+
- docs/pr/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.md
128
- docs/dev/codex_commands.md
139
- docs/dev/commit_comment.txt
1410
- docs/dev/reports/change_summary.txt

‎docs/dev/reports/validation_checklist.txt‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
1-
[ ] samples/index.html still supports correct filter/search behavior
2-
[ ] repeated filter/search interactions remain responsive
3-
[ ] favorites / pins can be added
4-
[ ] favorites / pins persist locally after reload
5-
[ ] favorites / pins can be removed and removal persists
1+
[ ] BUILD delta is limited to browse visuals and navigation
2+
[ ] thumbnails render when available
3+
[ ] missing previews fall back cleanly
4+
[ ] hover preview works without breaking layout
5+
[ ] navigation remains correct
66
[ ] Phase 13 samples 1316, 1317, 1318 still load
77
[ ] no console errors in tested pages
88
[ ] no gameplay changes
99
[ ] no engine-core changes
10-
[ ] changed-file count stayed minimal
11-
[ ] ZIP exists at <project folder>/tmp/BUILD_PR_SAMPLES_INDEX_PERFORMANCE_AND_PERSONALIZATION.zip
10+
[ ] ZIP exists at <project folder>/tmp/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.zip

‎docs/pr/APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION.md‎

Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
# APPLY_PR_SAMPLES_BROWSE_VISUALS_AND_NAVIGATION
2+
3+
## Objective
4+
Apply the completed BUILD wave for samples browse visuals and navigation.
5+
6+
This APPLY covers the already-built scope:
7+
- preview assets and thumbnails
8+
- hover preview
9+
- navigation polish
10+
11+
Canonical path contract remains:
12+
- `samples/phaseXX/XXYY/index.html`
13+
14+
## Apply Scope
15+
- apply the BUILD output exactly
16+
- preserve canonical sample paths
17+
- preserve metadata-driven readable UI
18+
- preserve sample runtime behavior
19+
- preserve Windows-safe zero-dependency execution standards
20+
21+
## Do Not
22+
- do not broaden scope
23+
- do not add unrelated cleanup
24+
- do not modify gameplay
25+
- do not modify engine core
26+
- do not redesign metadata schema
27+
- do not add new PR purpose beyond applying this BUILD
28+
29+
## Required Apply Checks
30+
1. Confirm the BUILD ZIP contents are scoped only to browse visuals and navigation.
31+
2. Apply the BUILD delta cleanly.
32+
3. Validate representative runtime behavior:
33+
- thumbnails render when available
34+
- fallback renders cleanly when previews are absent
35+
- hover preview does not break layout
36+
- next / previous / related navigation remains correct
37+
- Phase 13 samples 1316, 1317, 1318 still load
38+
4. Report exact files changed.
39+
5. Produce APPLY ZIP output.
40+
41+
## Acceptance Criteria
42+
- BUILD delta applied cleanly
43+
- no canonical path changes
44+
- no gameplay changes
45+
- no engine-core changes
46+
- browse visuals/navigation behavior works as validated
47+
- repo-structured delta ZIP is produced under `<project folder>/tmp/`
48+
49+
## Fail Fast
50+
Stop and report if:
51+
- BUILD contents exceed the approved scope
52+
- apply would require unrelated conflict resolution
53+
- canonical paths would change
54+
- the ZIP cannot be produced at the exact requested path

0 commit comments

Comments
 (0)