Skip to content

Commit 5539765

Browse files
author
DavidQ
committed
Fix Asset Manager V2 accordions and add planned tools entry - PR_26126_087-asset-manager-v2-accordion-and-planned-tools
1 parent 8d0861f commit 5539765

11 files changed

Lines changed: 416 additions & 669 deletions

‎docs/dev/reports/PR_26126_087_asset_manager_v2_accordion_behavior_notes.md‎

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
# PR_26126_087 Asset Manager V2 Accordion Behavior Notes
2+
3+
Date: 2026-05-06
4+
5+
## Scope
6+
7+
- Output Summary and Status remain in the right Asset Manager V2 panel.
8+
- Output Summary now has an explicit `asset-manager-v2__accordion--output` layout hook.
9+
- Status keeps its explicit `asset-manager-v2__accordion--status` layout hook.
10+
- The Status header remains a non-nested button pattern: the header is keyboard-focusable with `role="button"`, while the Clear button stays inside the same visual header row.
11+
12+
## Behavior
13+
14+
- Output Summary collapse:
15+
- toggles `aria-expanded` from `true` to `false`
16+
- sets `#inspectorContent.hidden`
17+
- shrinks the Output Summary section to header height
18+
- releases vertical space in the right panel
19+
- Output Summary expand:
20+
- restores `#inspectorContent`
21+
- lets `#inspectorOutput` fill the available content height above Status
22+
- Status collapse:
23+
- toggles `aria-expanded` from `true` to `false`
24+
- sets `#statusLogContent.hidden`
25+
- shrinks the Status section to header height
26+
- keeps the collapsed Status header at the bottom-right of the right panel
27+
- Status expand:
28+
- restores the status log content
29+
- keeps the expanded Status section at the bottom-right
30+
31+
## Layout Notes
32+
33+
- The right panel uses `justify-content: space-between` so Output Summary stays at the top and Status stays at the bottom when either section collapses.
34+
- Expanded Output Summary uses flexible height; expanded Status uses a fixed 260px basis.
35+
- Collapsed right-panel accordions use `flex: 0 0 auto` and hidden content, so they release vertical space.
36+
37+
## Validation
38+
39+
- `npm run test:workspace-v2`: passed, 10 tests.
40+
- Playwright asserts Output Summary collapse/expand, Status collapse/expand, hidden content state, section height shrinkage, Output Summary fill behavior, and Status bottom placement.
41+
- A direct browser layout probe during implementation measured Status at 15px from the right-panel bottom after Output Summary collapsed, after Output Summary re-expanded, and after Status collapsed.
42+

‎docs/dev/reports/PR_26126_087_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
# PR_26126_087 Asset Manager V2 Manual Validation Notes
2+
3+
Date: 2026-05-06
4+
5+
## Validation Performed
6+
7+
- Ran `npm run test:workspace-v2`.
8+
- Confirmed Asset Manager V2 tool mode launch.
9+
- Confirmed Asset Manager V2 Workspace V2 launch mode still works.
10+
- Confirmed Output Summary accordion collapses and expands.
11+
- Confirmed Status accordion collapses and expands.
12+
- Confirmed collapsed right-panel sections release vertical space.
13+
- Confirmed Status remains bottom-right when expanded.
14+
- Confirmed the planned tools list includes:
15+
- Asset Manager V2
16+
- Animation / Flipbook Editor
17+
- Audio / SFX Playground
18+
- Collision / Hitbox Editor
19+
- Confirmed no new planned tools beyond the requested/existing planned-tool set were added.
20+
- Confirmed no sample JSON files were modified.
21+
22+
## Results
23+
24+
- `npm run test:workspace-v2`: passed, 10 tests.
25+
- Output Summary accordion: passed. Collapse hides `#inspectorContent`, shrinks the section, and expand restores the filled output content area.
26+
- Status accordion: passed. Collapse hides `#statusLogContent`, shrinks the section, and expand restores the status log.
27+
- Status bottom-right placement: passed. Status stays at the bottom of the right panel when expanded and after Output Summary collapse/expand.
28+
- Planned tools list: passed. Asset Manager V2 is now listed as planned, and the existing Animation / Flipbook Editor, Audio / SFX Playground, and Collision / Hitbox Editor entries remain present.
29+
- Tool/browser launch validation: passed through the workspace-v2 Playwright suite.
30+
31+
## Reports
32+
33+
- `docs/dev/reports/playwright_v8_coverage_report.txt`
34+
- `docs/dev/reports/coverage_changed_js_guardrail.txt`
35+
- `docs/dev/reports/PR_26126_087_asset_manager_v2_accordion_behavior_notes.md`
36+
- `docs/dev/reports/PR_26126_087_asset_manager_v2_manual_validation_notes.md`
37+

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 14 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -3,28 +3,22 @@ M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
55
M tools/asset-manager-v2/index.html
6-
M tools/asset-manager-v2/js/AssetManagerV2App.js
7-
M tools/asset-manager-v2/js/assetManagerMetadata.js
8-
M tools/asset-manager-v2/js/bootstrap.js
9-
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
10-
M tools/asset-manager-v2/js/controls/AssetFormControl.js
6+
M tools/asset-manager-v2/js/controls/AccordionSection.js
117
M tools/asset-manager-v2/styles/assetManager.css
12-
?? docs/dev/reports/PR_26126_086_asset_manager_v2_manual_validation_notes.md
13-
?? docs/dev/reports/PR_26126_086_asset_manager_v2_ui_control_notes.md
8+
M tools/index.html
9+
?? docs/dev/reports/PR_26126_087_asset_manager_v2_accordion_behavior_notes.md
10+
?? docs/dev/reports/PR_26126_087_asset_manager_v2_manual_validation_notes.md
1411

1512
# git ls-files --others --exclude-standard
16-
docs/dev/reports/PR_26126_086_asset_manager_v2_manual_validation_notes.md
17-
docs/dev/reports/PR_26126_086_asset_manager_v2_ui_control_notes.md
13+
docs/dev/reports/PR_26126_087_asset_manager_v2_accordion_behavior_notes.md
14+
docs/dev/reports/PR_26126_087_asset_manager_v2_manual_validation_notes.md
1815

1916
# git diff --stat
20-
docs/dev/reports/coverage_changed_js_guardrail.txt | 10 +--
21-
docs/dev/reports/playwright_v8_coverage_report.txt | 27 +++---
22-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 97 ++++++++++++++++------
23-
tools/asset-manager-v2/index.html | 16 +---
24-
tools/asset-manager-v2/js/AssetManagerV2App.js | 67 +++++----------
25-
tools/asset-manager-v2/js/assetManagerMetadata.js | 14 ++++
26-
tools/asset-manager-v2/js/bootstrap.js | 3 -
27-
.../js/controls/AssetCatalogControl.js | 33 ++++++--
28-
.../js/controls/AssetFormControl.js | 7 +-
29-
tools/asset-manager-v2/styles/assetManager.css | 48 ++++++++---
30-
10 files changed, 193 insertions(+), 129 deletions(-)
17+
docs/dev/reports/coverage_changed_js_guardrail.txt | 1 +
18+
docs/dev/reports/playwright_v8_coverage_report.txt | 4 +-
19+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 62 ++++++++++++++++++++++
20+
tools/asset-manager-v2/index.html | 6 +--
21+
.../js/controls/AccordionSection.js | 7 +++
22+
tools/asset-manager-v2/styles/assetManager.css | 13 ++++-
23+
tools/index.html | 8 +++
24+
7 files changed, 95 insertions(+), 6 deletions(-)

0 commit comments

Comments
 (0)