Skip to content

Commit 8d0861f

Browse files
author
DavidQ
committed
Polish Asset Manager V2 asset display and output panel behavior - PR_26126_086-asset-manager-v2-assets-display-polish
1 parent 78c2c83 commit 8d0861f

14 files changed

Lines changed: 870 additions & 637 deletions

‎docs/dev/reports/PR_26126_086_asset_manager_v2_manual_validation_notes.md‎

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,35 @@
1+
# PR_26126_086 Asset Manager V2 Manual Validation Notes
2+
3+
Date: 2026-05-06
4+
5+
## Validation Performed
6+
7+
- Ran `npm run test:workspace-v2`.
8+
- Confirmed Asset Manager V2 tool mode launch.
9+
- Confirmed Asset Manager V2 Workspace V2 launch mode.
10+
- Confirmed image background filename role auto-selection.
11+
- Confirmed image bezel filename role auto-selection.
12+
- Confirmed Assets heading, sorted asset tile rendering, and per-tile Delete.
13+
- Confirmed Schema Validation controls are removed from the UI.
14+
- Confirmed Output Summary fills available right-panel height and Status remains below it at the bottom-right.
15+
- Confirmed Workspace V2 insertion still writes only to `tools.asset-browser.assets`.
16+
- Confirmed no sample JSON files were modified.
17+
18+
## Results
19+
20+
- `npm run test:workspace-v2`: passed, 10 tests.
21+
- Role auto-selection: passed. `nebula-background.png` selected Role `background`; `chrome-bezel.png` selected Role `bezel`.
22+
- Assets sorting: passed. Tiles rendered in type/role/ID order: `audio:sound`, `image:background`, `image:bezel`.
23+
- Asset tiles: passed. Each tile showed `type:role`, ID, and Delete.
24+
- Per-asset delete: passed. Deleting `image.assets.nebula-background.background` removed its tile and logged the delete.
25+
- Removed Schema Validation UI: passed. The schema validation accordion, JSON textarea, and validation buttons were absent.
26+
- Output Summary layout: passed. Output Summary content filled the available right-panel area above Status; Status stayed at the bottom-right.
27+
- Workspace insertion: passed. Audio selection inserted `audio.assets.fire.sound` into `tools.asset-browser.assets` and did not create `asset-manager-v2` or `workspace-v2` manifest entries.
28+
- Asset Browser reuse check: passed by targeted search of Asset Manager V2 files; no legacy Asset Browser implementation imports were added.
29+
30+
## Reports
31+
32+
- `docs/dev/reports/playwright_v8_coverage_report.txt`
33+
- `docs/dev/reports/coverage_changed_js_guardrail.txt`
34+
- `docs/dev/reports/PR_26126_086_asset_manager_v2_ui_control_notes.md`
35+
- `docs/dev/reports/PR_26126_086_asset_manager_v2_manual_validation_notes.md`

‎docs/dev/reports/PR_26126_086_asset_manager_v2_ui_control_notes.md‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
# PR_26126_086 Asset Manager V2 UI Control Notes
2+
3+
Date: 2026-05-06
4+
5+
## Controls
6+
7+
- Image filenames containing `background` now auto-select Role `background`.
8+
- Image filenames containing `bezel` now auto-select Role `bezel`.
9+
- Renamed the center panel heading from `Approved Assets` to `Assets`.
10+
- Removed the visible Schema Validation accordion and its JSON textarea/buttons.
11+
- Kept Status in the bottom-right panel under Output Summary.
12+
- Adjusted Output Summary so its content area flexes to fill the available right-panel height above Status.
13+
14+
## Assets Display
15+
16+
- Assets render as tiles instead of full-width row buttons.
17+
- Each tile shows:
18+
- type and role as `type:role`
19+
- asset ID
20+
- a per-asset `Delete` button under the type:role area
21+
- Tile display order is type, then role, then ID.
22+
- Delete removes the selected asset through the same schema-validated payload path used by Add.
23+
24+
## Boundaries
25+
26+
- No legacy Asset Browser implementation imports were added.
27+
- No sample JSON files were modified.

‎docs/dev/reports/codex_changed_files.txt‎

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -2,29 +2,29 @@
22
M docs/dev/reports/coverage_changed_js_guardrail.txt
33
M docs/dev/reports/playwright_v8_coverage_report.txt
44
M tests/playwright/PreviewGeneratorV2Baseline.spec.mjs
5-
M tools/asset-manager-v2/README.md
65
M tools/asset-manager-v2/index.html
6+
M tools/asset-manager-v2/js/AssetManagerV2App.js
77
M tools/asset-manager-v2/js/assetManagerMetadata.js
88
M tools/asset-manager-v2/js/bootstrap.js
9+
M tools/asset-manager-v2/js/controls/AssetCatalogControl.js
910
M tools/asset-manager-v2/js/controls/AssetFormControl.js
1011
M tools/asset-manager-v2/styles/assetManager.css
11-
?? docs/dev/reports/PR_26126_085_asset_manager_v2_manual_validation_notes.md
12-
?? docs/dev/reports/PR_26126_085_asset_manager_v2_schema_validation_notes.md
13-
?? docs/dev/reports/PR_26126_085_asset_manager_v2_ui_control_notes.md
12+
?? docs/dev/reports/PR_26126_086_asset_manager_v2_manual_validation_notes.md
13+
?? docs/dev/reports/PR_26126_086_asset_manager_v2_ui_control_notes.md
1414

1515
# git ls-files --others --exclude-standard
16-
docs/dev/reports/PR_26126_085_asset_manager_v2_manual_validation_notes.md
17-
docs/dev/reports/PR_26126_085_asset_manager_v2_schema_validation_notes.md
18-
docs/dev/reports/PR_26126_085_asset_manager_v2_ui_control_notes.md
16+
docs/dev/reports/PR_26126_086_asset_manager_v2_manual_validation_notes.md
17+
docs/dev/reports/PR_26126_086_asset_manager_v2_ui_control_notes.md
1918

2019
# git diff --stat
21-
docs/dev/reports/coverage_changed_js_guardrail.txt | 5 +-
22-
docs/dev/reports/playwright_v8_coverage_report.txt | 16 +++---
23-
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 55 ++++++++++++-------
24-
tools/asset-manager-v2/README.md | 2 +-
25-
tools/asset-manager-v2/index.html | 46 ++++++++++++----
26-
tools/asset-manager-v2/js/assetManagerMetadata.js | 20 +++++--
27-
tools/asset-manager-v2/js/bootstrap.js | 2 +-
28-
.../js/controls/AssetFormControl.js | 62 +++++++++++++++-------
29-
tools/asset-manager-v2/styles/assetManager.css | 41 +++++++++++++-
30-
9 files changed, 181 insertions(+), 68 deletions(-)
20+
docs/dev/reports/coverage_changed_js_guardrail.txt | 10 +--
21+
docs/dev/reports/playwright_v8_coverage_report.txt | 27 +++---
22+
.../playwright/PreviewGeneratorV2Baseline.spec.mjs | 97 ++++++++++++++++------
23+
tools/asset-manager-v2/index.html | 16 +---
24+
tools/asset-manager-v2/js/AssetManagerV2App.js | 67 +++++----------
25+
tools/asset-manager-v2/js/assetManagerMetadata.js | 14 ++++
26+
tools/asset-manager-v2/js/bootstrap.js | 3 -
27+
.../js/controls/AssetCatalogControl.js | 33 ++++++--
28+
.../js/controls/AssetFormControl.js | 7 +-
29+
tools/asset-manager-v2/styles/assetManager.css | 48 ++++++++---
30+
10 files changed, 193 insertions(+), 129 deletions(-)

0 commit comments

Comments
 (0)