Skip to content

Commit 322be55

Browse files
author
DavidQ
committed
Remove unused JSON files and stale metadata references verified by audit count reduction - PR 11.56
1 parent 7e50413 commit 322be55

26 files changed

Lines changed: 463 additions & 361 deletions

‎docs/dev/codex_commands.md‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
1-
# Codex Commands - PR 11.52
1+
# Codex Command — PR 11.56
22

33
Model: GPT-5.4
4-
Reasoning: medium
4+
Reasoning: high
55

66
```powershell
7-
codex --model gpt-5.4 --reasoning medium "Run PR 11.52 controlled JSON cleanup batch 8. Follow docs/pr/PR_11_52_CONTROLLED_JSON_CLEANUP_8.md exactly. Run the audit script, select exactly eight safe tool-specific NO JSON files, manually validate direct and broader references, remove only proven unused files, update docs/dev/reports/PR_11_52_audit_report.md with before/after counts and validation evidence, update only roadmap status markers if execution-backed, and package the final repo-structured artifact at tmp/PR_11_52_CONTROLLED_JSON_CLEANUP_8.zip. Do not run the full sample suite unless shared loader/framework files are changed."
7+
codex exec --model gpt-5.4 --reasoning high "Run PR 11.56 exactly as documented in docs/pr/PR_11_56_METADATA_REFERENCE_CLEANUP.md. This is controlled cleanup mode. Remove up to exactly 8 audit NO JSON files only when there are no runtime references. If the only remaining reference is metadata/index JSON such as samples/metadata/samples.index.metadata.json, delete the unused JSON file and remove the stale metadata/index reference. Save before/after audit reports under docs/dev/reports. Prove the audit NO/missing-reference count decreases or fail the PR. Do not run the full samples suite unless shared loader/framework files are changed. Do not touch sample 1902, palette.json, or tile-map-editor-document.json. Do not rewrite roadmap content. Return a repo-structured ZIP at tmp/PR_11_56_METADATA_REFERENCE_CLEANUP.zip."
88
```

‎docs/dev/commit_comment.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Remove 8 additional unused tool-specific JSON files verified by audit script - PR 11.52
1+
Remove unused JSON files and stale metadata references verified by audit count reduction - PR 11.56

‎docs/dev/reports/PR_11_54_audit_after.txt‎

19.7 KB
Binary file not shown.

‎docs/dev/reports/PR_11_54_audit_before.txt‎

19.7 KB
Binary file not shown.

‎docs/dev/reports/PR_11_54_candidate_reference_checks.md‎

Lines changed: 49 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,49 @@
1+
# PR 11.54 Candidate Reference Checks
2+
3+
## samples/phase-02/0201/sample.0201.3d-camera-path-editor.json
4+
- auditStatusBefore: NO
5+
- directJsSearch: (no matches)
6+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:1029: "presetPath": "/samples/phase-02/0201/sample.0201.3d-camera-path-editor.json"
7+
- decision: KEEP (indirect manifest reference present)
8+
9+
## samples/phase-02/0202/sample.0202.3d-camera-path-editor.json
10+
- auditStatusBefore: NO
11+
- directJsSearch: (no matches)
12+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:1075: "presetPath": "/samples/phase-02/0202/sample.0202.3d-camera-path-editor.json"
13+
- decision: KEEP (indirect manifest reference present)
14+
15+
## samples/phase-02/0210/sample.0210.physics-sandbox.json
16+
- auditStatusBefore: NO
17+
- directJsSearch: (no matches)
18+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:1429: "presetPath": "/samples/phase-02/0210/sample.0210.physics-sandbox.json"
19+
- decision: KEEP (indirect manifest reference present)
20+
21+
## samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json
22+
- auditStatusBefore: NO
23+
- directJsSearch: (no matches)
24+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:1957: "presetPath": "/samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json"
25+
- decision: KEEP (indirect manifest reference present)
26+
27+
## samples/phase-05/0510/sample.0510.asset-pipeline-tool.json
28+
- auditStatusBefore: NO
29+
- directJsSearch: (no matches)
30+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:4359: "presetPath": "/samples/phase-05/0510/sample.0510.asset-pipeline-tool.json"
31+
- decision: KEEP (indirect manifest reference present)
32+
33+
## samples/phase-05/0512/sample.0512.performance-profiler.json
34+
- auditStatusBefore: NO
35+
- directJsSearch: (no matches)
36+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:4440: "presetPath": "/samples/phase-05/0512/sample.0512.performance-profiler.json"
37+
- decision: KEEP (indirect manifest reference present)
38+
39+
## samples/phase-07/0708/sample.0708.replay-visualizer.json
40+
- auditStatusBefore: NO
41+
- directJsSearch: (no matches)
42+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:5262: "presetPath": "/samples/phase-07/0708/sample.0708.replay-visualizer.json"
43+
- decision: KEEP (indirect manifest reference present)
44+
45+
## samples/phase-16/1606/sample.1606.physics-sandbox.json
46+
- auditStatusBefore: NO
47+
- directJsSearch: (no matches)
48+
- broadRepoSearchExcludingDocsTmp: .\samples\metadata\samples.index.metadata.json:8855: "presetPath": "/samples/phase-16/1606/sample.1606.physics-sandbox.json"
49+
- decision: KEEP (indirect manifest reference present)

‎docs/dev/reports/PR_11_54_controlled_json_cleanup_8_report.md‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,56 @@
1+
# PR 11.54 Controlled JSON Cleanup Report
2+
3+
Codex must complete this report during execution.
4+
5+
## Initial Audit Counts
6+
- YES: 39
7+
- NO: 55
8+
- TOTAL: 94
9+
10+
## Removed Files
11+
No files removed.
12+
13+
Reason:
14+
- Under PR 11.54 constraints, all safe tool/debug/utility `NO` candidates tested had broader repo references in `samples/metadata/samples.index.metadata.json` via `roundtripToolPresets.presetPath`.
15+
- BUILD explicitly disallows touching shared manifests and ambiguous indirect-use files, so these candidates were kept.
16+
17+
## Reference Checks
18+
For each removed file, document direct JS and broad repo search results.
19+
20+
Validated candidate set (8):
21+
1. `samples/phase-02/0201/sample.0201.3d-camera-path-editor.json`
22+
2. `samples/phase-02/0202/sample.0202.3d-camera-path-editor.json`
23+
3. `samples/phase-02/0210/sample.0210.physics-sandbox.json`
24+
4. `samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json`
25+
5. `samples/phase-05/0510/sample.0510.asset-pipeline-tool.json`
26+
6. `samples/phase-05/0512/sample.0512.performance-profiler.json`
27+
7. `samples/phase-07/0708/sample.0708.replay-visualizer.json`
28+
8. `samples/phase-16/1606/sample.1606.physics-sandbox.json`
29+
30+
Results summary for all 8:
31+
- direct JS check: no matches
32+
- broad repo check (excluding docs/tmp): manifest reference found in `samples/metadata/samples.index.metadata.json`
33+
- decision: KEEP (indirect manifest reference present; ambiguous indirect-use risk)
34+
35+
Full evidence:
36+
- `docs/dev/reports/PR_11_54_candidate_reference_checks.md`
37+
- `docs/dev/reports/PR_11_54_audit_before.txt`
38+
39+
## Targeted Validation
40+
Document affected samples/tools opened and console/runtime results.
41+
42+
Performed:
43+
- Ran `scripts/PS/audit-sample-json-js-references.ps1` before and after cleanup.
44+
- Ran targeted direct JS and broad repo reference checks for all 8 candidates.
45+
- No runtime/framework files changed.
46+
47+
Outcome:
48+
- No deletions were safe under current PR constraints.
49+
50+
## Full Samples Suite
51+
Skipped. Reason: cleanup is limited to confirmed unused JSON files; no shared loader/framework change.
52+
53+
## Final Audit Counts
54+
- YES: 39
55+
- NO: 55
56+
- TOTAL: 94

‎docs/dev/reports/PR_11_56_metadata_reference_cleanup_report.md‎

Lines changed: 69 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,69 @@
1+
# PR 11.56 Metadata Reference Cleanup Report
2+
3+
## Summary
4+
Controlled cleanup mode executed successfully.
5+
6+
- Removed JSON files: 8
7+
- Removed stale metadata references: 8 (`samples/metadata/samples.index.metadata.json`)
8+
- Protected scope honored: no `palette.json`, no `tile-map-editor-document.json`, no sample 1902, no loader/framework edits.
9+
10+
## Before Audit
11+
Source: `docs/dev/reports/pr_11_56_before_audit.txt`
12+
13+
- YES: 39
14+
- NO (missing-reference): 55
15+
- TOTAL scanned JSON: 94
16+
17+
## Selected Candidates (8)
18+
1. `samples/phase-02/0201/sample.0201.3d-camera-path-editor.json`
19+
2. `samples/phase-02/0202/sample.0202.3d-camera-path-editor.json`
20+
3. `samples/phase-02/0210/sample.0210.physics-sandbox.json`
21+
4. `samples/phase-02/0220/sample.0220.3d-camera-path-editor.json`
22+
5. `samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json`
23+
6. `samples/phase-03/0303/sample.0303.physics-sandbox.json`
24+
7. `samples/phase-05/0510/sample.0510.asset-pipeline-tool.json`
25+
8. `samples/phase-05/0512/sample.0512.performance-profiler.json`
26+
27+
## Reference Classification Evidence
28+
Source: `docs/dev/reports/pr_11_56_candidate_classification.md`
29+
30+
For each selected file:
31+
- Direct JS check: no matches
32+
- Runtime reference check: only `samples/metadata/samples.index.metadata.json` presetPath hit
33+
- Broad repo check (excluding docs/tmp/.git): only `samples.index.metadata.json` hit
34+
- Classification: `SAFE_DELETE_WITH_METADATA_CLEANUP`
35+
36+
## Cleanup Actions
37+
Source: `docs/dev/reports/pr_11_56_cleanup_actions.json`
38+
39+
- Deleted 8 JSON files.
40+
- Removed 8 stale `roundtripToolPresets` entries from `samples/metadata/samples.index.metadata.json`.
41+
42+
Metadata removal verification:
43+
- `docs/dev/reports/pr_11_56_post_cleanup_checks.md`
44+
45+
## After Audit
46+
Source: `docs/dev/reports/pr_11_56_after_audit.txt`
47+
48+
- YES: 39
49+
- NO (missing-reference): 47
50+
- TOTAL scanned JSON: 86
51+
52+
## Required Count Proof
53+
- Before NO count: 55
54+
- After NO count: 47
55+
- Decrease: 8
56+
57+
Result: pass (NO/missing-reference count decreased by the number of deleted audit-counted JSON files).
58+
59+
## Targeted Validation Only
60+
- Ran audit script before and after.
61+
- Ran per-candidate direct JS/runtime/broad repo classification checks.
62+
- Verified deleted filenames are no longer present in metadata preset paths.
63+
64+
## Full Samples Suite
65+
Skipped.
66+
67+
Reason:
68+
- No shared loader/framework files changed.
69+
- PR scope limited to controlled JSON + stale metadata reference cleanup.

‎docs/dev/reports/pr_11_56_after_audit.txt‎

17.6 KB
Binary file not shown.

‎docs/dev/reports/pr_11_56_before_audit.txt‎

19.7 KB
Binary file not shown.

‎docs/dev/reports/pr_11_56_candidate_classification.md‎

Lines changed: 59 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,59 @@
1+
# PR 11.56 Candidate Classification
2+
3+
## samples/phase-02/0201/sample.0201.3d-camera-path-editor.json
4+
- auditNO: yes
5+
- directJs: (no matches)
6+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:1029: "presetPath": "/samples/phase-02/0201/sample.0201.3d-camera-path-editor.json"
7+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:1029: "presetPath": "/samples/phase-02/0201/sample.0201.3d-camera-path-editor.json"
8+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
9+
10+
## samples/phase-02/0202/sample.0202.3d-camera-path-editor.json
11+
- auditNO: yes
12+
- directJs: (no matches)
13+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:1075: "presetPath": "/samples/phase-02/0202/sample.0202.3d-camera-path-editor.json"
14+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:1075: "presetPath": "/samples/phase-02/0202/sample.0202.3d-camera-path-editor.json"
15+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
16+
17+
## samples/phase-02/0210/sample.0210.physics-sandbox.json
18+
- auditNO: yes
19+
- directJs: (no matches)
20+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:1429: "presetPath": "/samples/phase-02/0210/sample.0210.physics-sandbox.json"
21+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:1429: "presetPath": "/samples/phase-02/0210/sample.0210.physics-sandbox.json"
22+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
23+
24+
## samples/phase-02/0220/sample.0220.3d-camera-path-editor.json
25+
- auditNO: yes
26+
- directJs: (no matches)
27+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:1895: "presetPath": "/samples/phase-02/0220/sample.0220.3d-camera-path-editor.json"
28+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:1895: "presetPath": "/samples/phase-02/0220/sample.0220.3d-camera-path-editor.json"
29+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
30+
31+
## samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json
32+
- auditNO: yes
33+
- directJs: (no matches)
34+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:1957: "presetPath": "/samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json"
35+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:1957: "presetPath": "/samples/phase-02/0221/sample.0221.3d-json-payload-normalizer.json"
36+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
37+
38+
## samples/phase-03/0303/sample.0303.physics-sandbox.json
39+
- auditNO: yes
40+
- directJs: (no matches)
41+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:2427: "presetPath": "/samples/phase-03/0303/sample.0303.physics-sandbox.json"
42+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:2427: "presetPath": "/samples/phase-03/0303/sample.0303.physics-sandbox.json"
43+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
44+
45+
## samples/phase-05/0510/sample.0510.asset-pipeline-tool.json
46+
- auditNO: yes
47+
- directJs: (no matches)
48+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:4359: "presetPath": "/samples/phase-05/0510/sample.0510.asset-pipeline-tool.json"
49+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:4359: "presetPath": "/samples/phase-05/0510/sample.0510.asset-pipeline-tool.json"
50+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
51+
52+
## samples/phase-05/0512/sample.0512.performance-profiler.json
53+
- auditNO: yes
54+
- directJs: (no matches)
55+
- runtimeRefs(samples/tools/tests): samples\metadata\samples.index.metadata.json:4440: "presetPath": "/samples/phase-05/0512/sample.0512.performance-profiler.json"
56+
- broadRefs(excluding docs/tmp/.git): .\samples\metadata\samples.index.metadata.json:4440: "presetPath": "/samples/phase-05/0512/sample.0512.performance-profiler.json"
57+
- classification: SAFE_DELETE_WITH_METADATA_CLEANUP
58+
59+
safeCount: 8

0 commit comments

Comments
 (0)