Skip to content

feat: add binary search on answer template with example use case#14582

Open
meenaksh06 wants to merge 3 commits intoTheAlgorithms:masterfrom
meenaksh06:binary-search-on-answers
Open

feat: add binary search on answer template with example use case#14582
meenaksh06 wants to merge 3 commits intoTheAlgorithms:masterfrom
meenaksh06:binary-search-on-answers

Conversation

@meenaksh06
Copy link
Copy Markdown

Describe your change:

  • [x ] Add an algorithm
  • Fix a bug or typo in an existing algorithm
  • Add or change doctests
  • Documentation change

Improved the existing Binary Search on Answer implementation by:

  • Adding comprehensive doctests to validate correctness
  • Covering important edge cases (boundary conditions, monotonic checks)
  • Ensuring all doctests pass successfully with automated testing

These changes improve reliability and make the implementation easier to understand and verify.


Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword.

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required labels Apr 25, 2026
Copy link
Copy Markdown

@algorithms-keeper algorithms-keeper Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Click here to look at the relevant links ⬇️

🔗 Relevant Links

Repository:

Python:

Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.

algorithms-keeper commands and options

algorithms-keeper actions can be triggered by commenting on this PR:

  • @algorithms-keeper review to trigger the checks for only added pull request files
  • @algorithms-keeper review-all to trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.

NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.


def can_ship(capacity: int) -> bool:
days_used = 1
current = 0
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is no test file in this pull request nor any test function or class in the file searches/binary_search_on_answers.py, please provide doctest for the function can_ship

@algorithms-keeper algorithms-keeper Bot added the tests are failing Do not merge until tests pass label Apr 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required tests are failing Do not merge until tests pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant