fix: v2 - fix validation rules#2210
Open
maxy-shpfy wants to merge 1 commit intomasterfrom
Open
Conversation
🎩 PreviewA preview build has been created at: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Adds a pipeline-level
valuefield toInputthat is distinct fromdefaultValue. This field represents a runtime-configured value set directly on a pipeline input (via YAMLvalue), and is now round-tripped through serialization/deserialization, exposed through the component spec proxy, and validated.A new validation rule (
MISSING_PIPELINE_INPUT_VALUE) emits a warning when a required root pipeline input has neither adefaultValuenor avalueset. This check is skipped for embedded subgraph specs (nested pipelines), which are now explicitly flagged via a newisEmbeddedSubgraphproperty onComponentSpec. ThesetEmbeddedSubgraph(true)call is applied consistently wherever subgraph specs are created or deserialized.Additionally, a new validation rule (
MISSING_REQUIRED_ANNOTATION) is introduced to flag required launcher task annotations that are missing or empty, surfacing these as errors on the relevant task.The shared
isPipelineInputMissingConfiguredValuehelper consolidates the trim-aware "has a configured value" check, replacing the previous inline logic invalidations.tsand aligning it with the new model-layer validation.Resolution guidance for both new issue codes is wired into the
ValidationIssueResolutionCard.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Previously "missed value" was ignore, now it is "warning"
Screen Recording 2026-05-05 at 12.28.22 PM.mov (uploaded via Graphite)
Test Instructions
MISSING_PIPELINE_INPUT_VALUEwarning appears in the validation panel with the suggested resolution.defaultValueorvalueon that input — confirm the warning clears.MISSING_PIPELINE_INPUT_VALUEwarnings are raised for inputs inside the subgraph.MISSING_REQUIRED_ANNOTATIONerror appears.valueon an input — confirm the field is preserved.Additional Comments
The
isEmbeddedSubgraphflag replaces the previousskipInputConnectionValidationcontext flag that was threaded throughcollectIssues. Subgraph specs now carry this state intrinsically rather than relying on call-site context.