Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1f2377c28a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| surfaceId?: string, | ||
| ): UiAstReviewArtifact { | ||
| const targetSurface = findSurface(after, surfaceId); | ||
| const beforeSurface = findSurface(before, targetSurface.id); |
There was a problem hiding this comment.
buildUiAstReviewArtifact unconditionally calls findSurface(before, targetSurface.id), which throws when the reviewed surface exists only in the after AST (for example, first-time bootstrap or adding a new surface). That makes review artifact generation fail for a valid change type that diffUiAst already supports, so proposal/review flows cannot process surface additions.
Useful? React with 👍 / 👎.
| let verdict: UiAstRuntimeVerdictStatus; | ||
| let code = "runtime.observation.ok"; | ||
| if (hasRequiredDrift) { | ||
| verdict = policy === "strict" ? "block" : "warn"; |
There was a problem hiding this comment.
When required drift is present, the verdict logic maps every non-strict policy (including off) to warn, so policy off still emits drift warnings and non-allow fallbacks. This contradicts the repo’s established off semantics (checks disabled) and will create false runtime violations for surfaces intentionally configured with policy off.
Useful? React with 👍 / 👎.
1 participant
Summary
interfacectlTesting