Add visually hidden document labels to buttons for accessibility#1055
Open
nonprofittechy wants to merge 2 commits into
Open
Add visually hidden document labels to buttons for accessibility#1055nonprofittechy wants to merge 2 commits into
nonprofittechy wants to merge 2 commits into
Conversation
…emains same but download/view buttons have semantic labels
BryceStevenWilley
approved these changes
May 20, 2026
Contributor
BryceStevenWilley
left a comment
BryceStevenWilley
left a comment
There was a problem hiding this comment.
Tested with Voice Over on Mac and iPhone, works well on Mac, works on iPhone with a few quirks (it splits up the text inside each link, so that it reads "View [form title]", "View", "[form title]", "Download [form title]", "Download", "[form title]"). But each of those links still works, and the full context comes first, so I'm okay with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Style is unchanged, but this allows screen reader users to be able to tell what button they are interacting with. Tested with Narrator and NVDA in Windows; this seems like a good fix.
Can revisit/discuss including full document text in visible label with more of our user base, but this should be compatible for now.
Fix #1054
Note: we should also update translations to match as this involves some Docassemble template edits, not just in the Python code.
I tested with the test_aldocument.yml file.
Edit: 94a5e35 moves the default text for send_button_html() to the right place; also has side effect of making this more consistently translatable (must have been missed in a prior change)