Read Tyler versions from config files#376
Conversation
There was a problem hiding this comment.
Is this script used anywhere? TBH I don't see much use for it over keeping the config files organized.
| }; | ||
|
|
||
| if (!versionMap.containsKey(domain.jurisdiction())) { | ||
| String propertiesFile = "application." + domain.env().getName() + ".properties"; |
There was a problem hiding this comment.
This code looks good! But I think that it should happen at start time instead of call time; we can load the properties file at start time and put it into the STAGE_VERSION_MAP and PROD_VERSION_MAP that was there before, and specifically can check that the config file is formatted / written correctly right as the server starts (and ideally erroring out immediately), rather than waiting for a specific call to those services, where an error like this could hide for longer.
There was a problem hiding this comment.
Makes sense, I’ll load the config at startup and build the version maps from it so any config issues show up immediately
2 participants
Instead of hardcoding Tyler API versions(#218) in TylerClients.java, versions are now read from the existing application.stage.properties and application.prod.properties files in the config/ directory
To check configured versions locally use, bash scripts/tyler_versions.sh stage/ bash scripts/tyler_versions.sh prod