Fix handling of self-signed certs in s3_conn#1141
Merged
chess-knight merged 5 commits intomainfrom Apr 29, 2026
Merged
Conversation
mbuechse
approved these changes
Apr 28, 2026
Contributor
mbuechse
left a comment
mbuechse
left a comment
There was a problem hiding this comment.
Sorry for the long wait. I had to simplify the code a little because the double ternary, plus the unpythonic is True freaked me out a bit.
chess-knight
commented
Apr 29, 2026
chess-knight
commented
Apr 29, 2026
chess-knight
commented
Apr 29, 2026
Take insecure/verify/cacert parameter from clouds.yaml and pass it to boto3.resource. If insecure is True or verify is False use verify=False also for boto3. Else, if you provide cacert(via cacert or verify parameter) it is also used for boto3. If nothing from above is met, use verify=None to keep default boto3 behaviour. Signed-off-by: Roman Hros <roman.hros@dnation.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
thanks @chess-knight! Signed-off-by: Matthias Büchse <matthias.buechse@alasca.cloud>
chess-knight
force-pushed
the
fix/s3_conn
branch
from
bba2288 to
4a68b43
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take insecure/verify/cacert parameter from clouds.yaml and pass it to boto3.resource.
If insecure is True or verify is False use verify=False also for boto3.
Else, if you provide cacert(via cacert or verify parameter) it is also used for boto3.
If nothing from above is met, use verify=None to keep default boto3 behaviour.