Skip to content

Fix editData in HTML/UWP extensions allocating too much data #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AITYunivers wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix editData in HTML/UWP extensions allocating too much data #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DarkEdif/Bluewing Client/HTML5/Bluewing_Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ globalThis['darkEdif'] = (globalThis['darkEdif'] && globalThis['darkEdif'].sdkVe
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function(chkIDOrName) {
Expand Down
2 changes: 1 addition & 1 deletion DarkEdif/Bluewing Client/Wua/js/runtime/extensions/source/Bluewing_Client.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 19)
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function(chkIDOrName) {
Expand Down
6 changes: 4 additions & 2 deletions DarkEdif/DarkEdif Template/HTML5/DarkEdif_Template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,10 @@ globalThis['darkEdif'] = (globalThis['darkEdif'] && globalThis['darkEdif'].sdkVe

let editData = edPtrFile.readBuffer(
this.sizeBytes -
// skip area between eHeader -> Props
(ext.ho.privateData - 20) -
// skip eHeader
ext.ho.privateData -
// cursor offset
4 -
// Skip DarkEdif header
header.byteLength
);
Expand Down
6 changes: 4 additions & 2 deletions DarkEdif/DarkEdif Template/Wua/js/runtime/extensions/source/DarkEdif_Template.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,10 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 20)

let editData = edPtrFile.readBuffer(
this.sizeBytes -
// skip area between eHeader -> Props
(ext.ho.privateData - 20) -
// skip eHeader
ext.ho.privateData -
// cursor offset
4 -
// Skip DarkEdif header
header.byteLength
);
Expand Down
2 changes: 1 addition & 1 deletion DarkEdif/DarkScript/HTML5/DarkScript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ class DarkEdif {
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function (chkIDOrName) {
Expand Down
2 changes: 1 addition & 1 deletion DarkEdif/DarkScript/Wua/js/runtime/extensions/source/DarkScript.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ window['darkEdif'] = (window['darkEdif'] && window['darkEdif'].sdkVersion >= 19)
this.numProps = headerDV.getUint16(4 + 4 + 4, true); // Skip past hash and hashTypes
this.sizeBytes = headerDV.getUint32(4 + 4 + 4 + 4, true); // skip past numProps and pad

let editData = edPtrFile.readBuffer(this.sizeBytes - header.byteLength);
let editData = edPtrFile.readBuffer(this.sizeBytes - ext.ho.privateData - header.byteLength);
this.chkboxes = editData.slice(0, Math.ceil(this.numProps / 8));
let that = this;
let GetPropertyIndex = function(chkIDOrName) {
Expand Down