fix(fix): fail when .socket.facts.json is present in manifest files#1268
Merged
Martin Torp (mtorp) merged 1 commit intov1.xfrom Apr 24, 2026
Merged
Conversation
Previously socket fix silently filtered out any .socket.facts.json artifact before uploading manifests. Now the command fails fast and asks the user to delete the file before re-running. Bumps version to 1.1.86.
Benjamin Barslev Nielsen (barslev)
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
socket fixnow fails fast with a clear error when.socket.facts.json(a Coana analysis artifact) is found alongside collected manifest files, listing the offending paths and asking the user to delete them before re-running. Previously these files were silently filtered out before upload.1.1.86and adds a changelog entry.Test plan
pnpm checkpassessocket fixin a dir containing.socket.facts.json, verify error is clear and actionablesocket fixin a dir without.socket.facts.json, verify the command behaves as beforeNote
Low Risk
Low risk: small CLI behavior change limited to pre-upload validation and user-facing messaging, plus a routine version/changelog bump.
Overview
socket fixnow hard-fails if any.socket.facts.jsonfiles are discovered during manifest collection, returning a clear, actionable error that lists offending paths and instructs users to delete them before retrying (previously these files were silently filtered out before upload).Bumps the CLI version to
1.1.86and adds a corresponding changelog entry.Reviewed by Cursor Bugbot for commit 4a332e1. Configure here.