Skip to content

fix(fix): fail when .socket.facts.json is present in manifest files#1268

Merged
Martin Torp (mtorp) merged 1 commit intov1.xfrom
fix/socket-facts-json-manifest-check
Apr 24, 2026
Merged

fix(fix): fail when .socket.facts.json is present in manifest files#1268
Martin Torp (mtorp) merged 1 commit intov1.xfrom
fix/socket-facts-json-manifest-check

Conversation

@mtorp
Copy link
Copy Markdown
Contributor

@mtorp Martin Torp (mtorp) commented Apr 24, 2026

Summary

  • socket fix now fails fast with a clear error when .socket.facts.json (a Coana analysis artifact) is found alongside collected manifest files, listing the offending paths and asking the user to delete them before re-running. Previously these files were silently filtered out before upload.
  • Bumps version to 1.1.86 and adds a changelog entry.

Test plan

  • pnpm check passes
  • Manual: run socket fix in a dir containing .socket.facts.json, verify error is clear and actionable
  • Manual: run socket fix in a dir without .socket.facts.json, verify the command behaves as before

Note

Low Risk
Low risk: small CLI behavior change limited to pre-upload validation and user-facing messaging, plus a routine version/changelog bump.

Overview
socket fix now hard-fails if any .socket.facts.json files are discovered during manifest collection, returning a clear, actionable error that lists offending paths and instructs users to delete them before retrying (previously these files were silently filtered out before upload).

Bumps the CLI version to 1.1.86 and adds a corresponding changelog entry.

Reviewed by Cursor Bugbot for commit 4a332e1. Configure here.

Previously socket fix silently filtered out any .socket.facts.json
artifact before uploading manifests. Now the command fails fast and
asks the user to delete the file before re-running.

Bumps version to 1.1.86.
@mtorp Martin Torp (mtorp) marked this pull request as ready for review April 24, 2026 08:53
@mtorp Martin Torp (mtorp) merged commit dc8be10 into v1.x Apr 24, 2026
13 checks passed
@mtorp Martin Torp (mtorp) deleted the fix/socket-facts-json-manifest-check branch April 24, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants