Skip to content

rework ACF fields processing (WP-991) #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vsolovei-smartling wants to merge 9 commits into
base: master
Choose a base branch
from
Open

rework ACF fields processing (WP-991) #616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7c06d89
add get acf definition (WP-991)
vsolovei-smartling Apr 29, 2026
e755808
Merge branch 'master' into WP-991-fix-attachment-cloning-to-target-site
vsolovei-smartling May 13, 2026
03bac2c
use acf functions to process fields and groups (WP-991)
vsolovei-smartling May 13, 2026
ea58048
revert dependency changes (WP-991)
vsolovei-smartling May 13, 2026
e571b68
rework acf fields processing (WP-991)
vsolovei-smartling May 14, 2026
7949ea0
review changes (WP-991)
vsolovei-smartling May 14, 2026
fea464e
use public acf api (WP-991)
vsolovei-smartling May 14, 2026
a404423
add test (WP-991)
vsolovei-smartling May 14, 2026
c87193a
code style (WP-991)
vsolovei-smartling May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions inc/Smartling/Base/SmartlingCoreDownloadTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ public function downloadTranslationBySubmission(SubmissionEntity $entity): void
$entity->getFileUri(),
])
);
$data = (string)$this->getApiWrapper()->downloadFile($entity);
$data = $this->getApiWrapper()->downloadFile($entity);
$msg = vsprintf('Downloaded file for submission id = \'%s\'. Dump: %s', [$entity->getId(),
base64_encode($data)]);
$this->getLogger()->debug($msg);
Expand All @@ -74,9 +74,7 @@ public function downloadTranslationBySubmission(SubmissionEntity $entity): void
$entity->getTargetLocale(),
])
);
if (count($this->acfDynamicSupport->getDefinitions()) === 0) {
$this->acfDynamicSupport->run();
}
$this->acfDynamicSupport->runIfRequired();
$this->applyXML($entity, $data, $this->xmlHelper, $this->postContentHelper);
LiveNotificationController::pushNotification(
$this
Expand Down Expand Up @@ -122,12 +120,12 @@ public function downloadTranslationBySubmission(SubmissionEntity $entity): void
}
}

public function downloadTranslationBySubmissionId($id)
public function downloadTranslationBySubmissionId($id): void
{
do_action(ExportedAPI::ACTION_SMARTLING_DOWNLOAD_TRANSLATION, $this->loadSubmissionEntityById($id));
}

public function downloadTranslation($contentType, $sourceBlog, $sourceEntity, $targetBlog, $targetEntity = null)
public function downloadTranslation($contentType, $sourceBlog, $sourceEntity, $targetBlog, $targetEntity = null): void
{
$submission = $this->getTranslationHelper()
->prepareSubmission($contentType, $sourceBlog, $sourceEntity, $targetBlog, $targetEntity);
Expand Down
Loading