user interface fixes (WP-1001)#615
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
PavelLoparev
approved these changes
May 12, 2026
| } | ||
|
|
||
| public function acquireLock(ConfigurationProfileEntity $profile, string $key, int $ttlSeconds): \DateTime | ||
| public function acquireLock(ConfigurationProfileEntity $profile, string $key, float $ttlSeconds): \DateTime |
Contributor
There was a problem hiding this comment.
why float for seconds?
Contributor
Author
There was a problem hiding this comment.
Locks are short lived, but not short enough lived to be in milliseconds. The change fixes an issue no one noticed or complained about, where .001 in test lock function was silently converted to 1.
Contributor
There was a problem hiding this comment.
sorry, I still do not get. lock api accepts ttl in ms. you do not need to use float to describe fraction of a second
sl-mmuradov
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.