Migrate test discovery to use Rubydex#4064
Merged
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom Apr 28, 2026
Merged
Migrate test discovery to use Rubydex#4064vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
vinistock merged 1 commit intorubydex_adoption_feature_branchfrom
Conversation
vinistock
added
server
vinistock
commented
Apr 16, 2026
19 tasks
vinistock
force-pushed
the
rubydex_adoption_feature_branch
branch
from
9bf9d19 to
9ca38db
Compare
vinistock
force-pushed
the
vs_migrate_test_discovery
branch
2 times, most recently
from
94a4778 to
0966f07
Compare
vinistock
force-pushed
the
rubydex_adoption_feature_branch
branch
from
328b3db to
d1435ac
Compare
vinistock
force-pushed
the
vs_migrate_test_discovery
branch
from
0966f07 to
9a7f7e4
Compare
Morriar
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Migrate test discovery to use Rubydex.
Implementation
Since Rubydex handles incremental changes immediately on edits, we no longer need the complicated lazy indexing case. We can trust the graph to be up to date.
Automated Tests
There are still some incremental handling weirdness, so I made small adjustments to the tests to avoid it and unblock this migration.