[Tests] Replace real-time setTimeout with fake timers in plugin-cloudflare#7510
[Tests] Replace real-time setTimeout with fake timers in plugin-cloudflare#7510gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
…flare Refactored `packages/plugin-cloudflare/src/tunnel.test.ts` to use Vitest's fake timer API instead of a manual 250ms sleep. This improves test speed and reliability by making the timeout behavior deterministic. Added proper cleanup with `try...finally` to ensure real timers are restored even on failure.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The test suite for
@shopify/plugin-cloudflarecontained a test case that used a manual 250mssetTimeoutto wait for a tunnel timeout to occur. This pattern is non-deterministic, slow, and can lead to flakiness in CI environments.WHAT is this pull request doing?
This PR refactors
packages/plugin-cloudflare/src/tunnel.test.tsto use Vitest's fake timers.vi.useFakeTimers()andvi.advanceTimersByTimeAsync(250).try...finallyblock to ensurevi.useRealTimers()is always called, preventing global timer leakage to other tests.How to test your changes?
Run the unit tests for the affected package:
The tests should pass consistently and noticeably faster.
Duplicate check
I performed a duplicate check by searching the git logs for previous "Tester" PRs (using the
Juleslabel and[Tests]prefix in titles).Query:
git log --grep="[Tests]"andgit log --grep="Jules"Results: No previous PRs found addressing this specific file or using this technique in this subsystem.
Checklist
pnpm changeset add(N/A for test-only changes)PR created automatically by Jules for task 6152379681181735382 started by @gonzaloriestra