Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,10 @@ target-version = "py314"
[tool.ruff.lint]
select = ["E", "F", "I", "N", "W", "UP", "B", "C4", "SIM"]

[tool.ruff.lint.per-file-ignores]
# Inline HTML/CSS/JS template has unavoidably long lines
"s3proxy/admin/templates.py" = ["E501"]

[tool.pytest.ini_options]
asyncio_mode = "auto"
testpaths = ["tests"]
Expand Down
6 changes: 6 additions & 0 deletions s3proxy/admin/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
"""Admin dashboard for S3Proxy."""

from .collectors import record_request
from .router import create_admin_router

__all__ = ["create_admin_router", "record_request"]
44 changes: 44 additions & 0 deletions s3proxy/admin/auth.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
"""HTTP Basic Auth for admin dashboard."""

from __future__ import annotations

import secrets
from typing import TYPE_CHECKING

from fastapi import Depends, HTTPException, status
from fastapi.security import HTTPBasic, HTTPBasicCredentials

if TYPE_CHECKING:
from ..config import Settings

security = HTTPBasic(realm="S3Proxy Admin")
_security_dep = Depends(security)


def create_auth_dependency(settings: Settings, credentials_store: dict[str, str]):
"""Build a Basic Auth dependency using configured or AWS-derived credentials."""
if settings.admin_username and settings.admin_password:
valid_username = settings.admin_username
valid_password = settings.admin_password
elif credentials_store:
valid_username = next(iter(credentials_store.keys()))
valid_password = credentials_store[valid_username]
else:
raise RuntimeError("No credentials configured for admin auth")

async def verify(credentials: HTTPBasicCredentials = _security_dep):
ok_user = secrets.compare_digest(
credentials.username.encode(), valid_username.encode()
)
ok_pass = secrets.compare_digest(
credentials.password.encode(), valid_password.encode()
)
if not (ok_user and ok_pass):
raise HTTPException(
status_code=status.HTTP_401_UNAUTHORIZED,
detail="Invalid credentials",
headers={"WWW-Authenticate": 'Basic realm="S3Proxy Admin"'},
)
return credentials

return verify
Loading
Loading