Add add-sql-dialect agent skill#11
Merged
Merged
Conversation
Repo-local skill that captures the procedure for adding a seventh SQL dialect to pycel2sql, mirroring the equivalent skill in cel2sql Go and cel2sql4j Java but adapted to Python idioms (Dialect ABC, single-file dialect modules, Lark-based converter). Layout under .claude/skills/add-sql-dialect/: - SKILL.md (~110 lines) — quick start, picking-the-analogue table, critical surface methods, capabilities methods, IndexAdvisor decision, doc refresh, verification. - references/dialect-method-checklist.md — every method on the Dialect ABC grouped by category, with one-line "what to emit" guidance per method drawn from the six existing implementations. - references/test-files.md — exhaustive file-by-file checklist (code, tests, docs; optional integration + introspect support). - scripts/scaffold_dialect.py — copies an existing dialect file, renames the class, replaces every method body with NotImplementedError, prints the next manual steps. Refuses to overwrite. Walks up from __file__ to find the repo root, so it works from any cwd inside the repo. Lints clean against .claude/skills/skill-authoring/scripts/lint_skill.py. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of four maintenance skills (per the plan). Captures the procedure for adding a seventh SQL dialect to pycel2sql —
src/pycel2sql/dialect/<name>.py(subclass ofDialectABC),DialectNameenum,_REGISTRYfactory, parametrized tests, README badges.Mirrors the equivalent skill in cel2sql Go (PR #120) and cel2sql4j Java (PR #11), adapted to Python idioms.
Layout
SKILL.md(~110 lines) — quick start, picking-the-analogue table, critical surface methods, capabilities methods, IndexAdvisor decision, verification.references/dialect-method-checklist.md— every method on theDialectABC grouped by category, with one-line "what to emit" guidance per method drawn from the six existing implementations.references/test-files.md— exhaustive file-by-file checklist (code, tests, docs; optional integration + introspect support).scripts/scaffold_dialect.py— copies an existing dialect file, renames the class, replaces every method body withNotImplementedError, prints the next manual steps. Refuses to overwrite. Walks up from__file__so it works from any cwd inside the repo.Lint
Test plan
python .claude/skills/add-sql-dialect/scripts/scaffold_dialect.py duckdb cockroach Cockroachand confirm it creates a stubbedsrc/pycel2sql/dialect/cockroach.py(revert the file after — this is purely for verification)🤖 Generated with Claude Code