feat(SwapTokenPositions): v2 modular rewrite + new FX pipelines#2216
Open
steverobertsuk wants to merge 18 commits intoRoll20:masterfrom
Open
feat(SwapTokenPositions): v2 modular rewrite + new FX pipelines#2216steverobertsuk wants to merge 18 commits intoRoll20:masterfrom
steverobertsuk wants to merge 18 commits intoRoll20:masterfrom
Conversation
- Refactor SwapTokenPositions into a modular source architecture and generated bundle workflow. - Add configurable multi-phase FX flow with origin, travel, and destination stages plus timing controls. - Introduce new command flags, presets, instant mode, and settings validation support. - Keep backward compatibility for legacy flags with deprecation warnings and migration guidance. - Update metadata and documentation for the v2 command model, changelog, and testing notes. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk> Co-authored-by: Copilot <copilot@github.com>
- Add new travel visibility control via --travel-mode with normal and invisible options. - Add transport preset and update preset defaults for better Roll20 FX compatibility (including lightning/shadow adjustments). - Rework swap execution flow: - split phase timing into clearer origin, travel/swap, and destination windows - support invisible travel by temporarily moving tokens to GM layer, then revealing after swap - add swap verification retries before final success/failure handling - schedule destination FX after reveal/timing delays - Harden string flag parsing by normalizing quotes and trailing punctuation in flag values. - Extend config/state/help plumbing so travel mode is parsed, validated, persisted, and shown in override/settings output. - Update docs and metadata to reflect the new command model and test coverage (README, CHANGELOG, TESTING, script.json). - Update build metadata injection in Rollup/constants so build name/script/version/date are injected from script metadata. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk> Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…travel time Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…iles. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…ollisions. Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…ction Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk> Co-authored-by: Copilot <copilot@github.com>
… compatibility warnings Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
… addition of a developer guide for contributor setup and workflow Co-authored-by: Copilot <copilot@github.com>
…timing and delays Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
…age styling Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk> Co-authored-by: Copilot <copilot@github.com>
Signed-off-by: Steve Roberts <steve@shadowcomputers.co.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
--origin-fx,--travel-fx,--destination-fx.--origin-time,--travel-time,--destination-time,--swap-delay,--destination-delay.--travel-modewith valuesnormalandinvisible.portal,lightning,shadow,fire,magic,transport, andnone.--instantflag to force immediate swap.src/.rollup) to generate single-file artifacts for Roll20.Changed
--mode+ repeated beam cycle) with a staged pipeline (origin -> travel -> swap -> destination) driven by stage FX and timing flags.Deprecated
--mode(mapped for compatibility:beams->--preset lightning,transport->--preset transport)--duration(replaced by--swap-delay)--beam-fx(replaced by--travel-fx)--burst-fx(replaced by--destination-fx)