fix: add patch to fix rviz stuck in initializing on osx platform#9
fix: add patch to fix rviz stuck in initializing on osx platform#9Tobias-Fischer merged 1 commit intomainfrom
Conversation
wep21
commented
May 5, 2026
wep21
commented
- I've tested launching rviz locally on M5 MBA.
Signed-off-by: Daisuke Nishimatsu <daisuke@DaisukenoMacBook-Air.local>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 627f00525d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| + if (w != last_resize_width_ || h != last_resize_height_) { | ||
| + last_resize_width_ = w; | ||
| + last_resize_height_ = h; |
There was a problem hiding this comment.
This dedup check keys off the width/height arguments, but rviz_rendering::RenderWindow::windowMovedOrResized() intentionally calls impl_->resize(0, 0) as a sentinel (the same path used from RenderPanel::resizeEvent). With this change, those sentinel calls either become permanent no-ops (when the cache is already 0,0) or force a transient resize to 0,0 before the next real resize, so move/resize notifications are no longer propagated reliably. In practice this can break viewport updates after panel resizes or window moves because windowMovedOrResized() is now filtered by synthetic dimensions rather than the actual window size.
Useful? React with 👍 / 👎.
|
FYI @idesign0 that could be interested in this patch as well |
3 participants
