Skip to content

fix(download): resolve .app bundle paths after archive extraction#2

Merged
Robert27 merged 1 commit into
Robert27:mainfrom
alexpietsch:main
May 14, 2026
Merged

fix(download): resolve .app bundle paths after archive extraction#2
Robert27 merged 1 commit into
Robert27:mainfrom
alexpietsch:main

Conversation

@alexpietsch
Copy link
Copy Markdown
Contributor

Summary

iOS build artifacts from the remote cache are shipped as a tarball containing an application bundle (Something.app), which is a directory on disk. Path resolution after extraction only looked for files whose path ended in .app, so valid caches were never found and the flow failed with “Did not find any installable apps inside tarball.”

Changes

  • After extraction, locate iOS installs by recursively finding directories named *.app, without descending into a matched bundle.
  • When multiple bundles exist, pick the shallowest path; if depth ties, use lexicographic order on the relative path for a stable choice.
  • Android behavior is unchanged: still resolve a real .apk file.

Testing

  • Manually tested up-/download of cached packages for both iOS and Android
  • Extended __tests__/download.test.ts with cases for shallowest bundle preference and deterministic tie-breaking at the same depth.
  • Existing iOS/Android extraction tests continue to cover bundle directory layout, nested layout, and rejecting a plain file named *.app.

@alexpietsch alexpietsch requested a review from Robert27 as a code owner May 14, 2026 18:23
@Robert27 Robert27 merged commit 45112cd into Robert27:main May 14, 2026
1 check passed
@Robert27
Copy link
Copy Markdown
Owner

Thanks for your contribution, I'll push a new release soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants