New deliverable dependant download approach#2637
Open
tspslegr wants to merge 6454 commits into
Open
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the new approach - which I would like to have for all the Restcomm projects in the foreseeable future. This might not be the ultimate solution, as we would like to have ultimately ALL Mavenized and then getting rid of Ant & Bash would be required and all the deliverables dependencies could be Maven repo based, never less for now this process cleans the deliverables dependency, decouples projects build from downloads. Simplifies the mess around download links & versions.
Please @deruelle review the approach from over all perspective and @maria-farooq and @gvagenas review the changes to RC itself
! NOTE ! - @gvagenas the versions defined in the versions property file (ddd-versions.properties) are not most probably what we want to use for RC stable build for now, so please review and obtain the correct versions checking with the Media, Olympus, RVD, SipServlets teams before merging to RC master!
Thanks for feedback !
cheers
Pavel