Log Slowest Tests To Stdout And Github Summary If Possible#249
Open
kei-nan wants to merge 2 commits into
Open
Conversation
…e-queue coordinator Reconcile slowest-tests timing collection with PR RedisLabsModules#248's parallel-coordinator refactor (single results queue, per-test shutdown sentinels). Per-test timings are now reset and shipped on each per-test message and merged into self.testsTimings in the coordinator's bounded read loop, replacing the removed post-join summary loop. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
GuyAv46
reviewed
May 11, 2026
| finally: | ||
| after_func() | ||
|
|
||
| self.testsTimings.append((testFullName, time.monotonic() - startTime)) |
Contributor
There was a problem hiding this comment.
should this timing include the before_func and after_func? Consider setting the start time in the try (right before calling fn()) and the end time in the finally before the after_func
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #249 +/- ##
==========================================
+ Coverage 32.46% 34.02% +1.56%
==========================================
Files 17 17
Lines 2597 2716 +119
==========================================
+ Hits 843 924 +81
- Misses 1754 1792 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.