Send email domains to profile#802
Draft
PetarSimonovic wants to merge 2 commits intomainfrom
Draft
Conversation
Test coverage89.75% line coverage reported by SimpleCov. |
PetarSimonovic
force-pushed
the
send-email-domains-to-profile
branch
2 times, most recently
from
0de41bc to
615dfc5
Compare
PetarSimonovic
commented
May 1, 2026
Comment on lines
+603
to
+606
| it 'does not make a request to Profile API' do | ||
| update_school_email_domains_response | ||
| expect(WebMock).not_to have_requested(:patch, update_school_email_domains_url) | ||
| end |
Author
There was a problem hiding this comment.
I'm using WebMock rather than expanding ProfileApiMock given the TODO comment at the top of that module
PetarSimonovic
force-pushed
the
send-email-domains-to-profile
branch
from
615dfc5 to
34432b8
Compare
Allow the client to PATCH a collection of domains
Set up a job to update Profile's school email domains
PetarSimonovic
force-pushed
the
send-email-domains-to-profile
branch
from
34432b8 to
9570e79
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Points for consideration:
What's changed?
Description of what's been done - bullets are often best
Steps to perform after deploying to production
If the production environment requires any extra work after this PR has been deployed detail it here. This could be running a Rake task, a migration, or upgrading a Gem. That kind of thing.