Skip to content

[aomp] build_rocminfo.sh use CMAKE_PREFIX_PATH from build#2230

Merged
dpalermo merged 1 commit into
aomp-devfrom
dp_build_rocminfo
May 21, 2026
Merged

[aomp] build_rocminfo.sh use CMAKE_PREFIX_PATH from build#2230
dpalermo merged 1 commit into
aomp-devfrom
dp_build_rocminfo

Conversation

@dpalermo
Copy link
Copy Markdown
Contributor

@dpalermo dpalermo commented May 21, 2026 •
edited
Loading

Co-authored-by: Andrew Gozillon Andrew.Gozillon@amd.com

@dpalermo dpalermo requested a review from agozillon May 21, 2026 14:50
@dpalermo
Copy link
Copy Markdown
Contributor Author

dpalermo commented May 21, 2026

Fixes issue seen by Andrew on ringo due to the rocminfo build picking up the cmake files from the installed /opt/rocm/lib/cmake

/home/agozillo/git/aomp23.0/rocminfo/rocminfo.cc:784:38: error: ‘HSA_AMD_MEMORY_POOL_INFO_RUNTIME_ALLOC_REC_GRANULE’ was not declared in this scope; did you mean ‘HSA_AMD_MEMORY_POOL_INFO_RUNTIME_ALLOC_GRANULE’?
  784 |                                      HSA_AMD_MEMORY_POOL_INFO_RUNTIME_ALLOC_REC_GRANULE,
      |                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                      HSA_AMD_MEMORY_POOL_INFO_RUNTIME_ALLOC_GRANULE

agozillon
agozillon approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@agozillon agozillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dpalermo dpalermo merged commit 2fd79a2 into aomp-dev May 21, 2026
1 check passed
@dpalermo dpalermo deleted the dp_build_rocminfo branch May 21, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agozillon agozillon agozillon approved these changes

@estewart08 estewart08 Awaiting requested review from estewart08 estewart08 is a code owner

@gregrodgers gregrodgers Awaiting requested review from gregrodgers gregrodgers is a code owner

@ronlieb ronlieb Awaiting requested review from ronlieb ronlieb is a code owner

@zGoldthorpe zGoldthorpe Awaiting requested review from zGoldthorpe zGoldthorpe is a code owner

@carlobertolli carlobertolli Awaiting requested review from carlobertolli carlobertolli is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dpalermo @agozillon