[CI] run_llama.sh: Fix all shellcheck warnings#2229
Open
mhalk wants to merge 1 commit into
Open
Conversation
Quote default-assignment expansions (SC2223) and variable references in the cmake invocation (SC2086) to prevent globbing and word splitting. Add shellcheck source directive for the external aomp_common_vars include. Co-authored-by: Cursor <cursoragent@cursor.com>
mhalk
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quote default-assignment expansions (SC2223) and variable references in the cmake invocation (SC2086) to prevent globbing and word splitting. Add shellcheck source directive for the external aomp_common_vars include.
Motivation
AOMP shellcheck lint pointed these out in another PR.
Technical Details
Test Plan
Test Result
Submission Checklist