[MiniQMC] Enable 'dev' target to run latest OMP impl#2225
Open
jplehr wants to merge 1 commit into
Open
Conversation
This allows to switch between running the old tag we used internally for some time and the most recent work on OMP_offload user branch. Sources go to different directory on checkout. CMake invocation is a bit different. Build directory is overwritten / reused.
jplehr
requested review from
carlobertolli,
estewart08,
gregrodgers,
ronlieb and
zGoldthorpe
as code owners
ro-i
approved these changes
May 18, 2026
|
|
||
| while getopts "v:" opt; do | ||
| case $opt in | ||
| v) MQMC_VERSION="$OPTARG" ;; |
Contributor
There was a problem hiding this comment.
this seems to be more or less a on/off switch for using dev instead of stable? In that case, it would maybe be simpler to just use a toggle. But in case we expect more variants for the version field to follow, the current design is more suitable ofc. Although maybe a check if the string is in the supported list of version names would be nice :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to switch between running the old tag we used internally for some time and the most recent work on OMP_offload user branch.
Sources go to different directory on checkout.
CMake invocation is a bit different.
Build directory is overwritten / reused.