Skip to content

Fix subfolder not being appended to path on Windows #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
VirxEC wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix subfolder not being appended to path on Windows #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a70e103
Include subfolder in Windows default path
VirxEC May 1, 2026
77c600f
Format project
VirxEC May 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ func (a *App) IgnoreMe(
func (a *App) GetDefaultPath(subfolder string) string {
if runtime.GOOS == "windows" {
localappdata := os.Getenv("LOCALAPPDATA")
return filepath.Join(localappdata, "RLBot5")
return filepath.Join(localappdata, "RLBot5", subfolder)
}

// assume linux
Expand Down
5 changes: 1 addition & 4 deletions frontend/src/components/AddBotpack.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,7 @@ import { App } from "../../bindings/gui";
import Modal from "./Modal.svelte";
import ProgressBar from "./ProgressBar.svelte";

const OFFICIAL_BOTPACK_REPOS = [
"RLBot/botpack",
"VirxEC/pytorch-archive",
];
const OFFICIAL_BOTPACK_REPOS = ["RLBot/botpack", "VirxEC/pytorch-archive"];

let {
visible = $bindable(false),
Expand Down
8 changes: 4 additions & 4 deletions frontend/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,26 +24,26 @@ const app: any = mount(App, {

export function parseJSON(item: string | null): any | null {
if (item === null) {
return null
return null;
}

try {
return JSON.parse(item);
} catch (e) {
console.warn("JSON Parse error", e)
console.warn("JSON Parse error", e);
return null;
}
}

export function parseSuperJSON(item: string | null): any | null {
if (item === null) {
return null
return null;
}

try {
return SuperJSON.parse(item);
} catch (e) {
console.warn("SuperJSON Parse error", e)
console.warn("SuperJSON Parse error", e);
return null;
}
}
Expand Down
6 changes: 3 additions & 3 deletions players.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,7 @@ type BotInfo struct {
Config BotConfig `json:"config"`
Loadout *LoadoutConfig `json:"loadout,omitempty"`
TomlPath string `json:"tomlPath"`
Icon string `json:"icon"`
Icon string `json:"icon"`
}

func (botInfo BotInfo) ToPlayerConfig(team uint32) *flat.PlayerConfigurationT {
Expand Down Expand Up @@ -280,7 +280,7 @@ func (a *App) GetBots(paths []string) []BotInfo {
}

// Read logo file and convert it to data url so the frontend can use it
var icon string;
var icon string
logo_data, err := os.ReadFile(logo_file)
if err != nil {
// only warn if the logo file was explicitly set
Expand All @@ -306,7 +306,7 @@ func (a *App) GetBots(paths []string) []BotInfo {
Config: conf,
Loadout: loadout,
TomlPath: potentialConfigPath,
Icon: icon,
Icon: icon,
})
}

Expand Down