Fix SIGNALduino protocol loader#163
Merged
Merged
Conversation
sidey79
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed8e9130cd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
elektron-bbs
approved these changes
Apr 29, 2026
sidey79
force-pushed
the
codex/fix-protocol-loader
branch
2 times, most recently
from
eddc366 to
706f252
Compare
sidey79
force-pushed
the
codex/fix-protocol-loader
branch
from
706f252 to
6326f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SIGNALduino_LoadProtocolHashcall inget TimingsListwith the currentFHEM::Devices::SIGNALduino::SD_Protocolsobject API.getProtocolList()back into the hash shape the surrounding code expects.controls_SD_TOOL.txtand extend the protocol package regression test to reject the removed loader call.Root Cause
SIGNALduino_LoadProtocolHashis no longer available asmain::SIGNALduino_LoadProtocolHashafter the move to the RFFHEM protocol package. Callingget TimingsListtherefore failed with an undefined subroutine error.Validation
git diff --checkFHEM::Devices::SIGNALduino::SD_Protocols: loaded 161 protocolsNot run successfully in this local environment:
prove -I/home/sven/git_repos/RFFHEM/lib t/load_protocol_package.tfails before executing tests becauseTest2::V1is not installed.perl -I/home/sven/git_repos/RFFHEM/lib -c FHEM/88_SIGNALduino_TOOL.pmfails before checking this change becauseHttpUtils.pmis not available in the local@INC.