Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 78 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Home Assistant core issue #167674 by ensuring that protocol v1 (pv == "1.0") devices that are not robot vacuums are treated as unsupported and skipped during discovery, instead of attempting to initialize them with the v1 vacuum trait stack.
Changes:
- Add a category guard for V1 devices in
device_creator, skipping non-vacuum categories as unsupported. - Introduce a regression test verifying that a non-vacuum V1 device is excluded and diagnostics counters reflect the skip.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
roborock/devices/device_manager.py |
Adds a V1-only category check (must be robot.vacuum.cleaner) and raises UnsupportedDeviceError otherwise. |
tests/devices/test_device_manager.py |
Adds coverage ensuring non-vacuum V1 devices are skipped and counted as unsupported in diagnostics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case DeviceVersion.V1: | ||
| if product.category != RoborockCategory.VACUUM: | ||
| raise UnsupportedDeviceError( | ||
| f"Device {device.name} has unsupported V1 category {product.category}: {product.model}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
should handle home-assistant/core#167674