DSC v3 resource for PSResourceGet by adityapatwardhan · Pull Request #1852 · PowerShell/PSResourceGet

adityapatwardhan · 2025-07-28T20:55:50Z

PR Summary

The initial implementation of DSC v3 resource for PSResourceGet. It include two resources, Repository and PSResources.

PR Context

PR Checklist

michaeltlombardi

Quick review pass on the manifests, looking at resource implementation next.

michaeltlombardi

A few more comments on the schema and implementation.

ThomasNieto · 2025-07-30T02:42:40Z

Is the plan to add a discover extension in DSC to be able to find these resource manifests? If so, is there an issue/pr for that?

michaeltlombardi · 2025-07-30T15:55:53Z

Is the plan to add a discover extension in DSC to be able to find these resource manifests? If so, is there an issue/pr for that?

@ThomasNieto yup! PowerShell/DSC#913 proposes a discovery extension for finding resource and extension manifests through the PSModulePath.

ThomasNieto · 2025-08-01T05:05:34Z

I logged PowerShell/DSC#1024 issue. PSResourceGet will also have the same issue since it uses NuGet version range syntax containing square brackets.

Gijsreyn · 2025-11-08T03:02:09Z

@adityapatwardhan - I think you've followed the news, but you should be able to define a single resource manifest now e.g.,:

// psresourceget.dsc.manifests.json
{
  "resources": [
    {
      "$schema": "https://aka.ms/dsc/schemas/v3/bundled/resource/manifest.json",
      "description": "Manage PowerShell resources using PSResourceGet.",
      "tags": [
        "linux",
        "windows",
        "macos",
        "powershell",
        "nuget"
      ],
      "type": "Microsoft.PowerShell.PSResourceGet/PSResourceList",
      "version": "0.0.1",
      "get": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "$Input | ./psresourceget.ps1 -resourcetype 'psresourcelist' -operation 'get'"
        ],
        "input": "stdin"
      },
      "set": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "$Input | ./psresourceget.ps1 -resourcetype 'psresourcelist' -operation set"
        ],
        "input": "stdin",
        "return": "stateAndDiff"
      },
      "export": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "./psresourceget.ps1 -resourcetype 'psresourcelist' -operation export"
        ],
        "input": "stdin"
      },
      "test": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "$Input | ./psresourceget.ps1 -resourcetype 'psresourcelist' -operation test"
        ],
        "input": "stdin",
        "return": "stateAndDiff"
      },
      "schema": {
        "embedded": {
          "$schema": "https://json-schema.org/draft/2020-12/schema",
          "title": "PSResourceList",
          "type": "object",
          "additionalProperties": false,
          "required": [
            "repositoryName"
          ],
          "properties": {
            "repositoryName": {
              "title": "Repository Name",
              "description": "The name of the repository from where the resources are acquired.",
              "type": "string"
            },
            "resources": {
              "title": "Resources",
              "description": "The list of resources to manage.",
              "type": "array",
              "items": {
                "$ref": "#/$defs/PSResource"
              },
              "minItems": 0
            },
            "_exist": {
              "$ref": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json"
            },
            "_inDesiredState": {
              "$ref": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/inDesiredState.json"
            }
          },
          "$defs": {
            "Scope": {
              "type": "string",
              "title": "Scope",
              "description": "Scope of the resource installation.",
              "enum": [
                "CurrentUser",
                "AllUsers"
              ]
            },
            "PSResource": {
              "type": "object",
              "additionalProperties": false,
              "required": [
                "name"
              ],
              "properties": {
                "name": {
                  "title": "Name",
                  "description": "The name of the resource.",
                  "type": "string"
                },
                "version": {
                  "title": "Version",
                  "description": "The version range of the resource.",
                  "type": "string",
                  "pattern": "^(\\[|\\()\\s*\\d+(\\.\\d+){0,2}(-[0-9A-Za-z-.]+)?\\s*(,\\s*(\\d+(\\.\\d+){0,2}(-[0-9A-Za-z-.]+)?)?\\s*(\\]|\\)))?$"
                },
                "scope": {
                  "title": "Scope",
                  "description": "The scope of the resource. Can be 'CurrentUser' or 'AllUsers'.",
                  "$ref": "#/$defs/Scope"
                },
                "repositoryName": {
                  "title": "Repository Name",
                  "description": "The name of the repository from where the resource is acquired.",
                  "type": "string"
                },
                "preRelease": {
                  "title": "Pre-Release version",
                  "description": "Indicates whether to include pre-release versions of the resource.",
                  "type": "boolean",
                  "default": false
                },
                "_exist": {
                  "$ref": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json"
                },
                "_inDesiredState": {
                  "$ref": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/inDesiredState.json"
                }
              }
            },
            "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json": {
              "$schema": "https://json-schema.org/draft/2020-12/schema",
              "$id": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json",
              "title": "Instance should exist",
              "description": "Indicates whether the DSC resource instance should exist.",
              "type": "boolean",
              "default": true,
              "enum": [
                false,
                true
              ]
            },
            "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/inDesiredState.json": {
              "$schema": "https://json-schema.org/draft/2020-12/schema",
              "$id": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/inDesiredState.json",
              "title": "Instance is in desired state",
              "description": "Indicates whether the DSC resource instance is in the desired state.",
              "type": "boolean",
              "default": true,
              "enum": [
                false,
                true
              ]
            }
          }
        }
      }
    },
    {
      "$schema": "https://aka.ms/dsc/schemas/v3/bundled/resource/manifest.json",
      "description": "Manage PowerShell repositories using PSResourceGet.",
      "tags": [
        "linux",
        "windows",
        "macos",
        "powershell",
        "nuget"
      ],
      "type": "Microsoft.PowerShell.PSResourceGet/Repository",
      "version": "0.0.1",
      "get": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "$Input | ./psresourceget.ps1 -resourcetype 'repository' -operation 'get'"
        ],
        "input": "stdin"
      },
      "set": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "$Input | ./psresourceget.ps1 -resourcetype 'repository' -operation set"
        ],
        "input": "stdin"
      },
      "delete": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "$Input | ./psresourceget.ps1 -resourcetype 'repository' -operation delete"
        ],
        "input": "stdin"
      },
      "export": {
        "executable": "pwsh",
        "args": [
          "-NoLogo",
          "-NonInteractive",
          "-NoProfile",
          "-ExecutionPolicy",
          "Bypass",
          "-Command",
          "./psresourceget.ps1 -resourcetype 'repository' -operation export"
        ],
        "input": "stdin"
      },
      "schema": {
        "embedded": {
          "$schema": "https://json-schema.org/draft/2020-12/schema",
          "title": "Repository",
          "description": "A PowerShell Resource repository from where to acquire the resources.",
          "type": "object",
          "additionalProperties": false,
          "allOf": [
            {
              "if": {
                "properties": {
                  "_exist": {
                    "const": false
                  }
                }
              },
              "then": {
                "required": [
                  "name"
                ]
              },
              "else": {
                "required": [
                  "name",
                  "uri"
                ]
              }
            }
          ],
          "properties": {
            "name": {
              "title": "Name",
              "description": "The name of the repository.",
              "type": "string"
            },
            "uri": {
              "title": "URI",
              "description": "The URI of the repository.",
              "type": "string",
              "format": "uri"
            },
            "trusted": {
              "title": "Trusted",
              "description": "Indicates whether the repository is trusted.",
              "type": "boolean"
            },
            "priority": {
              "title": "Priority",
              "description": "The priority of the repository. Lower numbers indicate higher priority.",
              "type": "integer",
              "minimum": 0,
              "maximum": 100
            },
            "repositoryType": {
              "title": "Repository Type",
              "description": "The type of the repository.",
              "$ref": "#/$defs/RepositoryType"
            },
            "_exist": {
              "$ref": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json"
            }
          },
          "$defs": {
            "RepositoryType": {
              "type": "string",
              "title": "Repository Type",
              "description": "The type of the repository. Can be 'Unknown', 'V2', 'V3', 'Local', 'NugetServer', or 'ContainerRegistry'.",
              "enum": [
                "Unknown",
                "V2",
                "V3",
                "Local",
                "NugetServer",
                "ContainerRegistry"
              ]
            },
            "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json": {
              "$schema": "https://json-schema.org/draft/2020-12/schema",
              "$id": "https://raw.githubusercontent.com/PowerShell/DSC/main/schemas/v3/resource/properties/exist.json",
              "title": "Instance should exist",
              "description": "Indicates whether the DSC resource instance should exist.",
              "type": "boolean",
              "default": true,
              "enum": [
                false,
                true
              ]
            }
          }
        }
      }
    }
  ]
}

Gijsreyn · 2025-11-08T04:17:09Z

I think the pattern for version should also slightly change to:

"pattern": "^((\\[|\\()[ \\t]*(>=|>|<=|<)?[ \\t]*\\d+(\\.\\d+){0,2}(-[0-9A-Za-z-.]+)?[ \\t]*(,[ \\t]*(>=|>|<=|<)?[ \\t]*(\\d+(\\.\\d+){0,2}(-[0-9A-Za-z-.]+)?)?[ \\t]*)?(\\]|\\))|\\d+(\\.\\d+){0,2}(-[0-9A-Za-z-.]+)?)$"

adityapatwardhan · 2026-02-28T00:51:54Z

@Gijsreyn - thanks for your comments. I would still maybe want to keep it separate files for two resources. Easier to understand. What do others think?

Also, I removed the pattern validation for the NuGet version ranges. It can get really unwieldy and difficult to maintain.

adityapatwardhan · 2026-03-02T17:54:01Z

/azp run

azure-pipelines · 2026-03-02T17:54:15Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-03-02T21:41:16Z

Close / Re-Open to re-kick off pipelines.

adityapatwardhan · 2026-04-07T01:14:47Z

/azp run

azure-pipelines · 2026-04-07T01:14:59Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T17:51:23Z

/azp run

azure-pipelines · 2026-04-07T17:51:38Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T21:49:40Z

/azp run

azure-pipelines · 2026-04-07T21:49:53Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T21:59:27Z

/azp run

azure-pipelines · 2026-04-07T21:59:40Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T22:12:00Z

/azp run

azure-pipelines · 2026-04-07T22:12:11Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T22:28:44Z

/azp run

azure-pipelines · 2026-04-07T22:28:58Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T22:47:23Z

/azp run

azure-pipelines · 2026-04-07T22:47:35Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-07T23:10:09Z

/azp run

azure-pipelines · 2026-04-07T23:10:22Z

Azure Pipelines successfully started running 1 pipeline(s).

SteveL-MSFT

Approving with suggestions

SteveL-MSFT · 2026-04-08T19:38:57Z

+    foreach ($resource in $allPSResources) {
+        foreach ($inputResource in $inputResources) {
+            if ($resource.Name -eq $inputResource.Name) {
+                Write-Trace -message "Found matching resource for input: $($inputResource.Name). Checking version constraints. Input version: $($inputResource.Version), Resource version: $($resource.Version)" -level trace


In general, if the output doesn't have risk of sensitive information (like raw input/output JSON), it would be better to have it as debug instead of trace if it's helpful to identify issues when there's a failure

Reviewed and updated wherever appropriate

adityapatwardhan · 2026-04-08T20:08:38Z

/azp run

azure-pipelines · 2026-04-08T20:08:53Z

Azure Pipelines successfully started running 1 pipeline(s).

adityapatwardhan · 2026-04-23T18:19:02Z

  powershellExecutable: pwsh
  buildDirectory: '.'
  useAzAuth: false
+  DSCVersion: '3.2.0-preview.14'


Consider using gh to find the latest release.

adityapatwardhan requested review from SydneyhSmith, alerickson and anamnavi as code owners July 28, 2025 20:55

adityapatwardhan changed the title ~~DSC v3 resource for PSResourceGet~~ WIP: DSC v3 resource for PSResourceGet Jul 28, 2025

adityapatwardhan marked this pull request as draft July 28, 2025 20:56

SteveL-MSFT requested review from mgreenegit, michaeltlombardi and theJasonHelmick July 28, 2025 21:28

michaeltlombardi reviewed Jul 28, 2025

View reviewed changes

SteveL-MSFT requested changes Jul 28, 2025

View reviewed changes

michaeltlombardi reviewed Jul 28, 2025

View reviewed changes

ThomasNieto reviewed Jul 30, 2025

View reviewed changes

Comment thread src/dsc/psresources.dsc.resource.json Outdated

ThomasNieto reviewed Jul 30, 2025

View reviewed changes

Comment thread src/dsc/repository.dsc.resource.json

ThomasNieto mentioned this pull request Oct 22, 2025

Class-based resource capabilities in module manifest PowerShell/DSC#852

Open

3 tasks

adityapatwardhan force-pushed the DscResource branch from feafc53 to 6df0729 Compare February 28, 2026 00:46

adityapatwardhan marked this pull request as ready for review March 2, 2026 17:54

adityapatwardhan requested a review from shammu1 as a code owner March 2, 2026 17:54

adityapatwardhan changed the title ~~WIP: DSC v3 resource for PSResourceGet~~ DSC v3 resource for PSResourceGet Mar 2, 2026

SteveL-MSFT requested a review from Copilot March 2, 2026 21:39

Copilot started reviewing on behalf of SteveL-MSFT March 2, 2026 21:39 View session

adityapatwardhan closed this Mar 2, 2026

Debug test

b6bf046

Add fileloadexception metadata in trace

7913f54

Remove verbose

cdc8b0f

Update to DSC preview 14

9053850

Load module from module under test

3f7c6a6

Cleanup

4f24955

Fix DSC download for macOS

62464ae

Fix test

bd14ec8

SteveL-MSFT approved these changes Apr 8, 2026

View reviewed changes

Address CR feedback from Steve

142f6cd

alerickson approved these changes Apr 21, 2026

View reviewed changes

adityapatwardhan commented Apr 23, 2026

View reviewed changes

Conversation

adityapatwardhan commented Jul 28, 2025

PR Summary

PR Context

PR Checklist

Uh oh!

michaeltlombardi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaeltlombardi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ThomasNieto commented Jul 30, 2025

Uh oh!

Uh oh!

Uh oh!

michaeltlombardi commented Jul 30, 2025

Uh oh!

ThomasNieto commented Aug 1, 2025

Uh oh!

Gijsreyn commented Nov 8, 2025

Uh oh!

Gijsreyn commented Nov 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adityapatwardhan commented Feb 28, 2026

Uh oh!

adityapatwardhan commented Mar 2, 2026

Uh oh!

azure-pipelines Bot commented Mar 2, 2026

Uh oh!

adityapatwardhan commented Mar 2, 2026

Uh oh!

adityapatwardhan commented Apr 7, 2026

Uh oh!

azure-pipelines Bot commented Apr 7, 2026

Uh oh!

adityapatwardhan commented Apr 7, 2026

Uh oh!

azure-pipelines Bot commented Apr 7, 2026

Uh oh!

adityapatwardhan commented Apr 7, 2026

Uh oh!

azure-pipelines Bot commented Apr 7, 2026

Uh oh!

adityapatwardhan commented Apr 7, 2026

Uh oh!

azure-pipelines Bot commented Apr 7, 2026

Uh oh!

adityapatwardhan commented Apr 7, 2026

Uh oh!

azure-pipelines Bot commented Apr 7, 2026

Uh oh!

adityapatwardhan commented Apr 7, 2026

Gijsreyn commented Nov 8, 2025 •

edited

Loading