Skip to content

Better reliability for FRLG auto-catching and species detection#1253

Merged
Mysticial merged 6 commits into
PokemonAutomation:mainfrom
theastrogoth:nidoran
May 22, 2026
Merged

Better reliability for FRLG auto-catching and species detection#1253
Mysticial merged 6 commits into
PokemonAutomation:mainfrom
theastrogoth:nidoran

Conversation

@theastrogoth
Copy link
Copy Markdown
Contributor

@theastrogoth theastrogoth commented May 21, 2026

This adds

  • Sprite matching for FRLG. Currently only used as a fallback for the summary reader if there are no good results from OCR or for double-checking Nidoran's gender
  • Sound detection for the fanfare that plays on a successful catch
  • Better handling of evolution after leveling up with Rare Candy

... all useful for making the FRLG Wild RNG program more reliable, particularly in the Safari Zone

Depends on PokemonAutomation/Packages#66

EDIT: also added a fix for the seed calibration bug reported by Sollisnexus

@theastrogoth theastrogoth marked this pull request as draft May 21, 2026 03:09
@theastrogoth theastrogoth marked this pull request as ready for review May 21, 2026 03:18
@theastrogoth theastrogoth reopened this May 21, 2026
@theastrogoth
Copy link
Copy Markdown
Contributor Author

All CI checks passed on one run or the other.

The first time, Windows checks failed ("The hosted runner lost communication with the server"). The second time ran into an issue with Ubuntu dependencies.

Happy to close and reopen this PR again to triple check if needed, but I figured it might be better to avoid it if it's not necessary.

@pifopi
Copy link
Copy Markdown
Member

pifopi commented May 21, 2026

You can rerun jobs at will ! Though GitHub seems to have issues lately with their runners. I know they're working on it. We'll see how it goes

@theastrogoth
Copy link
Copy Markdown
Contributor Author

I might be dumb and overlooking the place to do this in the Github web interface, but I think that rerunning CI jobs might be locked behind a particular permission/role.

Anyways, thanks for restarting the failed jobs! Looks like they got through the Ubuntu dependencies this time 🎉

@theastrogoth theastrogoth marked this pull request as draft May 22, 2026 00:03
@theastrogoth theastrogoth marked this pull request as ready for review May 22, 2026 02:06
@Mysticial Mysticial merged commit 04e37c5 into PokemonAutomation:main May 22, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants