Skip to content

🪲 [Fix]: Fix issues with docs#30

Merged
Marius Storhaug (MariusStorhaug) merged 3 commits intomainfrom
update
Oct 6, 2025
Merged

🪲 [Fix]: Fix issues with docs#30
Marius Storhaug (MariusStorhaug) merged 3 commits intomainfrom
update

Conversation

@MariusStorhaug
Copy link
Copy Markdown
Member

Description

This pull request introduces improvements to documentation and configuration for testing and linting. The main changes are an enhancement to the Test-Admin.ps1 function documentation and the addition of linter environment variable controls in the GitHub Actions workflow.

Documentation improvements:

  • Expanded the .DESCRIPTION and .EXAMPLE sections in the Test-Admin.ps1 function to clarify its purpose and usage, including a code example.

CI/CD configuration:

  • Added a Linter section to .github/PSModule.yml with environment variables to control various validation steps, allowing selective enabling/disabling of linting and formatting checks.

Copilot AI review requested due to automatic review settings October 6, 2025 09:58
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes documentation and CI/CD configuration issues by enhancing PowerShell function documentation and adding linter controls to the GitHub Actions workflow.

  • Enhanced the Test-Admin.ps1 function documentation with a proper description and formatted code example
  • Added linter configuration section to disable various validation checks in the CI/CD pipeline

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/functions/public/Test-Admin.ps1 Added description section and formatted code example block
.github/PSModule.yml Added linter environment variables to control validation steps

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/functions/public/Test-Admin.ps1 Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings October 6, 2025 11:53
@MariusStorhaug Marius Storhaug (MariusStorhaug) merged commit 7138945 into main Oct 6, 2025
2 checks passed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

.EXAMPLE
Test-Role
```pwsh
Test-Admin
Copy link

Copilot AI Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example section should include the expected output to make it more helpful for users. Consider adding a line showing what the function returns, such as '$true' or '$false'.

Suggested change
Test-Admin
Test-Admin
# Output (if running as Administrator/root)
$true

Copilot uses AI. Check for mistakes.
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 6, 2025

Module Admin - 1.1.11 published to the PowerShell Gallery.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 6, 2025

GitHub release for Admin v1.1.11 has been created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants