Bug/hindhi translation welcome sms optmiztion #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

May 6, 2026

Merged

fix welcome sms code

SonarQubeCloud / SonarCloud Code Analysis succeeded May 6, 2026 in 49s

Quality Gate passed

Define a constant instead of duplicating this literal "label" 3 times.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ38AprptsfJDtCC-uLs&open=AZ38AprptsfJDtCC-uLs&pullRequest=405

Make options a static final constant or non-public and provide accessors if needed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ38ApwWtsfJDtCC-uLv&open=AZ38ApwWtsfJDtCC-uLv&pullRequest=405

Refactor this method to reduce its Cognitive Complexity from 24 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ38ApuGtsfJDtCC-uLu&open=AZ38ApuGtsfJDtCC-uLu&pullRequest=405

Replace this usage of 'Stream.collect(Collectors.toList())' with 'Stream.toList()' and ensure that the list is unmodified.

See more on https://sonarcloud.io/project/issues?id=PSMRI_Common-API&issues=AZ38AprptsfJDtCC-uLt&open=AZ38AprptsfJDtCC-uLt&pullRequest=405