Add BrowseIPPSOnly boolean directive and update man page#1564
Add BrowseIPPSOnly boolean directive and update man page#1564abubakarsabir924-cell wants to merge 5 commits intoOpenPrinting:masterfrom
Conversation
a0aa34e to
7367e78
Compare
|
@michaelrsweet Sir! I have updated the PR with the following changes: |
b3396be to
a9f84a7
Compare
michaelrsweet
left a comment
There was a problem hiding this comment.
Some changes needed here...
The biggest thing seems to be testing BrowseIPPSOnly and the printer type to completely disable registration/deregistration. You want to test BrowseIPPSOnly in the dnssdRegisterPrinter function to determine whether to add the _ipp or _fax-ipp services but otherwise that should be all that is needed.
|
Ok Michael Sir, thank you for the detailed feedback! I will ping you once the updated changes are ready for review. Thank you for your guidance sir! |
a9f84a7 to
3a81e14
Compare
|
@michaelrsweet Sir. I've moved the logic to the beginning of dnssdRegisterPrinter, replaced raw hex with CUPS_PTYPE_REMOTE, and added the man page anchor as requested. |
michaelrsweet
left a comment
There was a problem hiding this comment.
Still need some changes...
|
Sir @michaelrsweet I've updated the PR with these specific fixes: Logic Cleaned: Removed the redundant check on line 481. Correct Wrapper: Wrapped the standard _ipp registration with if (!BrowseIPPSOnly) while keeping _ipps unconditional. Verified: Confirmed the build works perfectly with make. Please review and let me know if any further adjustments are needed to meet the project's standards, |
|
Sir Also, I just pushed an additional commit to initialize the num_txt and txt variables. This fixes the 'uninitialized variable' error that was causing the CI build to fail. Now the build should be green! |
Added the BrowseIPPSOnly directive in conf.c and conf.h.
Implemented the filtering logic in scheduler/dirsvc.c for both registration and deregistration.
Verified that the code compiles successfully with make.
Updated the manual page cupsd.conf.5 with the new directive description.
The implementation ensures only IPPS services are advertised when the directive is enabled.