fix: disable inspector in config and update layout reference#175
Merged
fix: disable inspector in config and update layout reference#175
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the MageForge Inspector (toolbar) opt-in by default and conditionally renders the frontend layout block based on a configuration flag.
Changes:
- Set
dev/mageforge_inspector/enableddefault value to0in module config. - Update the frontend
mageforge.inspectorlayout block to render only whendev/mageforge_inspector/enabledis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/view/frontend/layout/default.xml |
Adds ifconfig to conditionally include the inspector block (and removes cacheable="false"). |
src/etc/config.xml |
Disables the inspector by default via <enabled>0</enabled>. |
Co-authored-by: Copilot <copilot@github.com>
dermatz
force-pushed
the
fix/inspector-cache-hit
branch
from
19a0283 to
fe9a82b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the configuration and layout for the MageForge Inspector feature to better control its availability. The inspector block is now conditionally displayed based on a configuration setting, and the feature is disabled by default in the development configuration.
Configuration changes:
<enabled>to0insrc/etc/config.xml.Frontend/layout changes:
mageforge.inspectorblock insrc/view/frontend/layout/default.xmlto display only if the configurationdev/mageforge_inspector/enabledis set, replacing the unconditional display and removing thecacheableattribute.