Fix Sherpa local ASR state sync#522
Closed
weikeyi wants to merge 1 commit into
Closed
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
摘要
tokenizer/目录校验和downloadedBytes统计。sherpa-onnx-local,并且 Sherpa 模型存在部分下载或已解压资源时允许删除。验证
git diff --check✅cargo check --manifest-path openless-all/app/src-tauri/Cargo.toml✅npm run build✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml sherpa --lib -- --nocapture✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml persist_settings --lib -- --nocapture✅cargo test --manifest-path openless-all/app/src-tauri/Cargo.toml --libasr::whisper::tests::transcribe_posts_single_request_without_chunk_limitasr::whisper::tests::transcribe_splits_requests_when_chunk_limit_is_set本 PR 未修改任何 Whisper 相关文件。
PR Type
Enhancement, Bug fix, Tests
Description
Sync active ASR provider to vault
Improve Sherpa archive validation
tokenizer/directoriesRecognize
sherpa-onnx-localin UIRefresh credentials on provider changes
Diagram Walkthrough
File Walkthrough
8 files
Add directory-aware Sherpa path validationUse path validation in catalog snapshotsAdd vault sync helpers for ASRSync preferences at Windows startupUpdate Sherpa API shapes and mocksEnable delete for extracted Sherpa modelsRefresh credentials for local ASR changesAdd Sherpa provider to local presets2 files
Verify downloads and count extracted bytesSync active ASR provider on persist