Document OIDC subject claim behaviour#3118
Draft
sathvikkumar-octo wants to merge 1 commit intomainfrom
Draft
Conversation
Clarifies that requested subject keys with no value in the current execution context (e.g. tenant on an untenanted deployment) are omitted entirely from the generated subject - both key and value - not just left with an empty value. Customers configuring AWS IAM trust policies for untenanted projects had to discover this by trial and error. Replaces the single 'default format' line with the default keys plus both the tenanted and untenanted resulting subjects, adds the missing Project Group key part, removes Feed from the Deployments and Runbooks allowed parts (Feed has its own subject config), and adds a tenanted/untenanted example pair to the AWS account doc.
sathvikkumar-octo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a selected OIDC subject key has no value at runtime (e.g.
tenanton an untenanted deployment), both the key and the value are dropped from the generatedsubclaim — not just the value. The docs didn't say this, and the documented "default format" included atenant:segment that doesn't actually appear for untenanted deployments. Reported internally after an AWS IAM trust policy was configured against the documented format and didn't match the actual subject.This PR:
Project Groupkey (already allowed in the code)Feedfrom the Deployments and Runbooks allowed parts (Feed has its own subject config)Source of truth:
OidcSubjectGenerator.cs