[18.0] [FIX] server_environment: no interpolation in the configparser

[AxelPrel]

Fixes #265

Hm, but this is a breaking change? What happens for users who have aready escaped % characeters in their configs.

[AxelPrel]

yes this is a breaking change. any user of the module that explicitely use the configparser with interpolation (ie %(my_variable)) will get no interpolation at all.
If the use of the parser is to be kept, then it must be documented in the module that this feature exists.
And I have to find another way to bypass this problem (maybe by a configuration key in the conf that tells the module what config to give the configparser, with or without interpolation)
If the use of the parser is just something that was forgotten when the module was made, then the change I proposed is to be kept. Your call

[AxelPrel]

oh, and any user that doubled their %, bypassing this problem, will also suffer from this change, since the escape will now be taken literally, they will see two %% instead of just one % before, i think this is what you meant

the escaping solution was not approved where we use this module, since we are talking about secrets that will eventually be placed directly in the conf by an external tool (apikeys, passwords, etc) and escaping the % at this stage, even though it fixed the problem, was considered a dirty workaround that was not approved. this is why i proposed this change

[sbidoul]

oh, and any user that doubled their %, bypassing this problem, will also suffer from this change, since the escape will now be taken literally, they will see two %% instead of just one % before, i think this is what you meant

Yes exactly that, I've been hit by that this week too...

But breaking that behaviour will make things awful for those who already escaped.

So let's make this configurable with a system parameter and some documentation?