Skip to content

#4174 frontend changes#4193

Open
wavehassman wants to merge 5 commits intofeature/descoping-crfrom
#4174-remove-old-cr-stuff
Open

#4174 frontend changes#4193
wavehassman wants to merge 5 commits intofeature/descoping-crfrom
#4174-remove-old-cr-stuff

Conversation

@wavehassman
Copy link
Copy Markdown
Contributor

@wavehassman wavehassman commented Apr 28, 2026

Changes

Removed all the old CR elements, updated diff to have bullets, and finished up CR view. This holds all the left frontend changes, so need to make sure it all works correctly.

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4174 #4175 #4180

@wavehassman wavehassman self-assigned this Apr 28, 2026
Copy link
Copy Markdown
Contributor

@cielbellerose cielbellerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks awesome just a few small things

Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx
Comment thread src/frontend/src/pages/WorkPackageForm/WorkPackageFormView.tsx Outdated
Copy link
Copy Markdown
Contributor

@staysgt staysgt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When I click edit on an existing project, make a change, and then click on 'change request' it doesn’t let me submit without selecting a reviewer
  • When I try to create a new project and make a change request for creating the project, I can’t find the new cr on the all change requests page

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants