#4152 Changed gantt chart tooltip location#4160
Open
AbhinavGonthina wants to merge 1 commit intofeature/gantt-chart-improvementsfrom
Open
#4152 Changed gantt chart tooltip location#4160AbhinavGonthina wants to merge 1 commit intofeature/gantt-chart-improvementsfrom
AbhinavGonthina wants to merge 1 commit intofeature/gantt-chart-improvementsfrom
Conversation
…tip appears near mouse (also edited y coordinate calculation for better readability)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Updated tooltip positioning on the Gantt chart so it follows where the user hovers instead of appearing in a fixed spot.
It now uses the mouse coordinates from the hover event and places the tooltip near the cursor.
Notes
I added an x coordinate prop into GanttTooltipProps such that the tooltip now is close to the user's cursor when they hover over a gantt chart element. I also changed the y coordinate calculation and variable declarations for better code readability and visibility.
Also, it seems that gantt elements which have subelements have the tooltip positions where the start of the sub element which is being hovered over is, but this is not a huge difference than what may be expected in my opinion.
Screenshots
Gantt.Chart.Tooltips.mp4
To Do
Change positioning of tooltip if needed.
Checklist
It can be helpful to check the
ChecksandFiles changedtabs.Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.
yarn.lockchanges (unless dependencies have changed)Closes #4152