Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
Pull request overview
This PR expands the repository’s Workload Factory API sample scripts and slightly extends the FSx for ONTAP AWS CLI filesystem creation helper to support additional request options.
Changes:
- Add new Workload Factory “builders” API samples for EDA project configuration, CI/CD projects, and CI/CD clones.
- Update multiple existing Workload Factory scripts’ required-parameter messaging for
CREDENTIALS_ID. - Extend
create_fsxn_filesystemto accept an alternate AWS endpoint URL and attempt to support updating route tables during FSx for ONTAP filesystem creation.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 35 comments.
Show a summary per file
| File | Description |
|---|---|
| Management-Utilities/fsx-ontap-aws-cli-scripts/create_fsxn_filesystem | Adds -route-tables and -endpoint_url support to FSxN filesystem creation/wait flow. |
| Management-Utilities/Workload-Factory-API-Samples/volume_delete | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/volume_clone | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/snapshot_create | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/list_volumes | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/list_svms | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/list_snapmirrors | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/list_filesystems | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/link_disassociate | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/link_associate | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/fsxn_credentials_set | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/bluexp_fsxn_discovery | Updates CREDENTIALS_ID required-option error messaging. |
| Management-Utilities/Workload-Factory-API-Samples/list_eda_project_config | New script to list EDA project config (“configure”) builder data. |
| Management-Utilities/Workload-Factory-API-Samples/list_cicd_projects | New script to list EDA CI/CD projects (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/list_cicd_clones | New script to list clones for a given CI/CD project (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/eda_project_config_delete | New script to delete EDA project config (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/eda_project_config_create | New script to create EDA project config (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/cicd_project_delete | New script to delete a CI/CD project (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/cicd_project_create | New script to create a CI/CD project (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/cicd_clones_delete | New script to delete a CI/CD clone (builders API). |
| Management-Utilities/Workload-Factory-API-Samples/cicd_clones_create | New script to create a CI/CD clone (builders API). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ct so the user didn't have to prvoide it; Created a new list_snapshots script so a user can easily get the snapshots; Updated list_cicd_project to list the volume_ID associated with the volume so it can be used with 'list_snapshots'.
…ct so the user didn't have to prvoide it; Created a new list_snapshots script so a user can easily get the snapshots; Updated list_cicd_project to list the volume_ID associated with the volume so it can be used with 'list_snapshots'.
… to specify a path.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 36 out of 36 changed files in this pull request and generated 21 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.