Skip to content

NPA-6620: Validate IAL3 as well as AAL3#340

Open
ehallam wants to merge 1 commit intomasterfrom
task/NPA-6620/validate-IAL3-and-AAL3
Open

NPA-6620: Validate IAL3 as well as AAL3#340
ehallam wants to merge 1 commit intomasterfrom
task/NPA-6620/validate-IAL3-and-AAL3

Conversation

@ehallam
Copy link
Copy Markdown
Contributor

@ehallam ehallam commented Apr 27, 2026

Pull Request

🧾 Ticket Link

https://nhsd-jira.digital.nhs.uk/browse/NPA-6620


📄 Description/Summary of Changes

  • Added the proxy updates as specified in the ticket

🧪 Developer Testing Carried Out

  • Tested it against internal-dev with the new proxy updates using AAL1, AAL2 and AAL3, and only AAL3 works like expected
  • We already rejected these requests before this change too
image

📋 PR Principles

  • Keep PRs Small and Focused: Ensure the PR addresses a single task or feature to make it easier to review.
  • Multiple PRs for one Ticket: When splitting work into multiple PRs, clearly describe what this PR addresses and outline the remaining work to complete the ticket.
  • Ensure Tests Are Included: Add or update unit, integration, or end-to-end tests to cover the changes made.
  • Follow Coding Standards: Ensure the code adheres to the team's coding guidelines and best practices.
  • Resolve Comments Promptly: If you raise a comment, ensure you follow up and resolve it before approving the PR to maintain clarity and ensure comments are addressed.
  • Foster Learning: PR reviews are an opportunity to share knowledge, provide constructive feedback, and encourage a collaborative environment.

🏷️ Naming Conventions Reminder

Please ensure the following naming conventions are followed:

  • PR title follows the format: NPA-XXXX: <short-description>
  • Branch name follows the convention: <type>/NPA-XXXX/<short-description>
  • Commit messages follow the template: NPA-XXXX: <short-description>

@github-actions
Copy link
Copy Markdown

This branch is work on a ticket in the NHS Digital NPA JIRA Project. Here's a handy link to the ticket:

NPA-6620

@ehallam ehallam marked this pull request as ready for review April 28, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant