CCM-17605: Enable component test sharding#323
Open
lapenna-bjss wants to merge 14 commits intomainfrom
Open
Conversation
lapenna-bjss
commented
May 5, 2026
| --terraformAction "apply" \ | ||
| --overrideProjectName "nhs" \ | ||
| --overrideRoleName "nhs-main-acct-digital-letters-github-deploy" \ | ||
| --internalRef "feature/CCM-17605_Enable_component_test_sharding" \ |
Collaborator
Author
There was a problem hiding this comment.
Temporarily pointing to the NHS Notify internal branch containing the sharding changes, as main does not yet support this. This will be reverted once that PR is merged.
lapenna-bjss
commented
May 5, 2026
| with: | ||
| target_environment: "pr${{ needs.metadata.outputs.pr_number }}" | ||
| target_account_group: nhs-notify-digital-letters-dev | ||
| internal_ref: "feature/CCM-17605_Enable_component_test_sharding" |
Collaborator
Author
There was a problem hiding this comment.
Temporarily pointing to the NHS Notify internal branch containing the sharding changes, as main does not yet support this. This will be reverted once that PR is merged.
sidnhs
reviewed
May 5, 2026
gareth-allan
reviewed
May 5, 2026
Contributor
gareth-allan
left a comment
gareth-allan
left a comment
There was a problem hiding this comment.
I think you could also now remove the constants that were used by the Firehose setup/teardown utilties.
Comment on lines
+23
to
+26
| internal_ref: | ||
| description: "Branch or ref to use in nhs-notify-internal (defaults to main)" | ||
| required: false | ||
| type: string |
Contributor
There was a problem hiding this comment.
I assume you'll remove this once the branch of nhs-notify-internal is merged?
sidnhs
previously approved these changes
May 5, 2026
simonlabarere
previously approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, component tests run in a single job using eight workers. This PR introduces test sharding to split the suite into smaller groups that run concurrently across multiple runners, reducing overall execution time.
Important changes
Terraform deployment
Before
After
Component tests
Before
After
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.