Support dogstatsd-ruby 5

.github/workflows/test.yml

@@ -51,28 +51,28 @@ jobs:
       if: ${{ needs.test.result != 'success' }}
       run: exit 1
 
-  notify:
-    # Run only on master, but regardless of whether tests past:
-    if: ${{ always() && github.ref == 'refs/heads/master' }}
-
-    needs: test_matrix
-
-    runs-on: ubuntu-latest
-
-    steps:
-    - uses: 8398a7/action-slack@v3
-      with:
-        status: custom
-        fields: workflow,commit,author
-        custom_payload: |
-          {
-            channel: 'C7FQWGDHP',
-            username: 'CI – ' + '${{ github.repository }}'.split('/')[1],
-            icon_emoji: ':hammer_and_wrench:',
-            attachments: [{
-              color: '${{ needs.test_matrix.result }}' === 'success' ? 'good' : '${{ needs.test_matrix.result }}' === 'failure' ? 'danger' : 'warning',
-              text: `${process.env.AS_WORKFLOW} against \`${{ github.ref }}\` (${process.env.AS_COMMIT}) for ${{ github.actor }} resulted in *${{ needs.test_matrix.result }}*.`
-            }]
-          }
-      env:
-        SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
+#  notify:
+#    # Run only on master, but regardless of whether tests past:
+#    if: ${{ always() && github.ref == 'refs/heads/master' }}
+#
+#    needs: test_matrix
+#
+#    runs-on: ubuntu-latest
+#
+#    steps:
+#    - uses: 8398a7/action-slack@v3
+#      with:
+#        status: custom
+#        fields: workflow,commit,author
+#        custom_payload: |
+#          {
+#            channel: 'C7FQWGDHP',
+#            username: 'CI – ' + '${{ github.repository }}'.split('/')[1],
+#            icon_emoji: ':hammer_and_wrench:',
+#            attachments: [{
+#              color: '${{ needs.test_matrix.result }}' === 'success' ? 'good' : '${{ needs.test_matrix.result }}' === 'failure' ? 'danger' : 'warning',
+#              text: `${process.env.AS_WORKFLOW} against \`${{ github.ref }}\` (${process.env.AS_COMMIT}) for ${{ github.actor }} resulted in *${{ needs.test_matrix.result }}*.`
+#            }]
+#          }
+#      env:
+#        SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## [Unreleased]
 ### Fixed
 * Support Ruby 3.4. Drop support for Rails 7.0, Ruby 3.1
+* Support dogstatsd-ruby 5
 
 ## 0.2.2 / 2024-11-19
 ### Added

ndr_stats.gemspec

@@ -20,7 +20,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'dogstatsd-ruby', '~> 4.5'
+  spec.add_dependency 'dogstatsd-ruby', '>= 4.5', '< 6.0'
 
   # We list development dependencies for all Rails versions here.
   # Rails version-specific dependencies can go in the relevant Gemfile.

test/ndr_stats_test.rb

@@ -19,8 +19,8 @@ def test_that_it_is_configurable
 
       adaptor = NdrStats.adaptor
       assert_kind_of Datadog::Statsd, adaptor
-      assert_equal 'test.host', adaptor.connection.host
-      assert_equal 9125, adaptor.connection.port
+      assert_equal 'test.host', adaptor.respond_to?(:host) ? adaptor.host : adaptor.connection.host
+      assert_equal 9125, adaptor.respond_to?(:port) ? adaptor.port : adaptor.connection.port
       assert_equal %w[system:app stack:live], adaptor.tags
     end
   end