Fix: [AEA-6533] - Handle Modification of User Messages#547
Open
kieran-wilkinson-4 wants to merge 13 commits intomainfrom
Open
Fix: [AEA-6533] - Handle Modification of User Messages#547kieran-wilkinson-4 wants to merge 13 commits intomainfrom
kieran-wilkinson-4 wants to merge 13 commits intomainfrom
Conversation
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
force-pushed
the
AEA-6533-Message-Edit-Issue
branch
from
d77ebeb to
c51b208
Compare
kieran-wilkinson-4
force-pushed
the
AEA-6533-Message-Edit-Issue
branch
from
c51b208 to
a6268f3
Compare
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
changed the title
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
Comment on lines
+558
to
+561
| has_user_replies = any(msg.get("user") == user_id for msg in subsequent_messages) | ||
|
|
||
| if has_user_replies: | ||
| _notify_diverged_conversation(client, channel, user_id, thread_ts, event_id) |
Contributor
There was a problem hiding this comment.
question:
is there a potential race condition between the has_user_replies check and the subsequent message deletion loop?
if a user posts a reply in that window, could their message be silently deleted with no ephemeral warning, would it be worth re-checking for user messages inside the deletion loop before each delete?
Contributor
Author
There was a problem hiding this comment.
The user messages can't be deleted by the bot (it doesn't have permission) - though, we don't even need a loop because we only delete the last message 🤷♀️
|
kieran-wilkinson-4
temporarily deployed
to
dev-pr
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Handles users modifying messages
Details
Examples:
Changing message without any follow up messages
Original:
Modified:
Changing message with follow up messages
Original:
Modified: