Skip to content

feat: [DTOSS-12154] provide a functionality to enable or disable shared access key#289

Merged
nc-shahidazim merged 1 commit intomainfrom
feat/DTOSS-12154-disable-sas
Apr 29, 2026
Merged

feat: [DTOSS-12154] provide a functionality to enable or disable shared access key#289
nc-shahidazim merged 1 commit intomainfrom
feat/DTOSS-12154-disable-sas

Conversation

@nc-shahidazim
Copy link
Copy Markdown
Contributor

@nc-shahidazim nc-shahidazim commented Apr 29, 2026

Description

This PR introduces a new configuration option to enable or disable Shared Access Key authentication for the Storage module.

Context

Some environments require disabling Shared Access Key access in favour of identity-based authentication. Providing this capability improves security posture and aligns the module with best practices and organizational policies.

Changes

  • Added a new module input to control Shared Access Key access.
  • When enabled, storage accounts allow Shared Access Key authentication.
  • When disabled, Shared Access Key authentication is explicitly turned off.

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@nc-shahidazim nc-shahidazim force-pushed the feat/DTOSS-12154-disable-sas branch from 8c78084 to f412d84 Compare April 29, 2026 10:56
@nc-shahidazim nc-shahidazim force-pushed the feat/DTOSS-12154-disable-sas branch from f412d84 to 69a898c Compare April 29, 2026 11:16
@nc-shahidazim nc-shahidazim marked this pull request as ready for review April 29, 2026 11:17
Copy link
Copy Markdown
Contributor

@MacMur85 MacMur85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@nc-shahidazim nc-shahidazim added this pull request to the merge queue Apr 29, 2026
Merged via the queue into main with commit d4f16d3 Apr 29, 2026
13 checks passed
@nc-shahidazim nc-shahidazim deleted the feat/DTOSS-12154-disable-sas branch April 29, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants