Skip to content

docs: fix Notification hook matcher example#2335

Open
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/hooks-notification-matcher-docs
Open

docs: fix Notification hook matcher example#2335
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/hooks-notification-matcher-docs

Conversation

@he-yufeng
Copy link
Copy Markdown

@he-yufeng he-yufeng commented May 20, 2026

Summary

  • replace the non-functional permission_prompt Notification hook example with real background-task notification types
  • correct the Notification matcher wording in the English and Chinese hook docs
  • update the hook config roundtrip fixture so it no longer preserves the broken matcher

Fixes #2330

To verify

  • uv run --package kimi-cli --group dev pytest tests/hooks/test_integration.py::test_config_roundtrip_toml tests/hooks/test_integration.py::test_notification_hook -q -p no:cacheprovider
  • uv run --package kimi-cli --group dev ruff check tests/hooks/test_integration.py
  • git diff --check

Note: running the whole tests/hooks/test_integration.py file on Windows still hits existing shell assumptions around bash/python3; the two tests touched by this patch pass.


Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: Hooks documentation example for desktop notification on approval is non-functional

1 participant