Skip to content

fix(web): open archived sessions from sidebar#2333

Open
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/web-archived-session-open
Open

fix(web): open archived sessions from sidebar#2333
he-yufeng wants to merge 1 commit into
MoonshotAI:mainfrom
he-yufeng:fix/web-archived-session-open

Conversation

@he-yufeng
Copy link
Copy Markdown

@he-yufeng he-yufeng commented May 20, 2026

Summary

  • let archived sessions resolve as the current session when selected
  • keep the URL/session validator from clearing a selected archived session
  • wait for archived-session pagination/loading before deciding a selected session is missing

Fixes #2312

To verify

  • npm ci
  • npm run typecheck
  • npm run lint
  • npm run build
  • git diff --check

Open in Devin Review

Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 2 additional findings.

Open in Devin Review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a95da22a2f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread web/src/App.tsx
Comment on lines +235 to 236
if (searchQuery.trim() || hasMoreSessions || hasMoreArchivedSessions || isLoadingArchived) {
return;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Do not block URL validation on archived pagination state

Guarding validation with hasMoreArchivedSessions causes ?session=... cleanup to be skipped indefinitely whenever the user has at least one additional archived page (e.g. >100 archived sessions) but never clicks “Load more”. In that case an invalid or deleted session ID remains selected forever, because this effect never reaches the sessionExists check even after initial archived loading finishes; previously this path only depended on active-session pagination.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Web UI: Clicking on archived sessions does not open them

1 participant