fix(web): open archived sessions from sidebar#2333
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a95da22a2f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (searchQuery.trim() || hasMoreSessions || hasMoreArchivedSessions || isLoadingArchived) { | ||
| return; |
There was a problem hiding this comment.
Do not block URL validation on archived pagination state
Guarding validation with hasMoreArchivedSessions causes ?session=... cleanup to be skipped indefinitely whenever the user has at least one additional archived page (e.g. >100 archived sessions) but never clicks “Load more”. In that case an invalid or deleted session ID remains selected forever, because this effect never reaches the sessionExists check even after initial archived loading finishes; previously this path only depended on active-session pagination.
Useful? React with 👍 / 👎.
Summary
Fixes #2312
To verify
npm cinpm run typechecknpm run lintnpm run buildgit diff --check